linux-kernel - Re: [PATCH] drm/arcgpu: fix device node leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4677bcd3-8e90-462a-bfe7-25ed35ea07ea@web.de>
Date: Wed, 19 Nov 2025 20:25:13 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>, dri-devel@...ts.freedesktop.org
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Alexey Brodkin <abrodkin@...opsys.com>, David Airlie <airlied@...il.com>,
 Hui Pu <Hui.Pu@...ealthcare.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Simona Vetter <simona.vetter@...ll.ch>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 Thomas Zimmermann <tzimmermann@...e.de>
Subject: Re: [PATCH] drm/arcgpu: fix device node leak

> This function gets a device_node reference via
> of_graph_get_remote_port_parent() and stores it in encoder_node, but necer

                                                                       never?


> puts that reference. Add it.
…
> +++ b/drivers/gpu/drm/tiny/arcpgu.c
> @@ -250,7 +250,8 @@ DEFINE_DRM_GEM_DMA_FOPS(arcpgu_drm_ops);
>  static int arcpgu_load(struct arcpgu_drm_private *arcpgu)
>  {
>  	struct platform_device *pdev = to_platform_device(arcpgu->drm.dev);
> -	struct device_node *encoder_node = NULL, *endpoint_node = NULL;
> +	struct device_node *encoder_node __free(device_node) = NULL;
> +	struct device_node *endpoint_node = NULL;
>  	struct drm_connector *connector = NULL;
>  	struct drm_device *drm = &arcpgu->drm;
>  	int ret;

May the scopes be reduced for any of these variables?

Regards,
Markus