linux-kernel - Re: [PATCH 3/6] gpu: nova-core: Blackwell: basic GPU identification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPM=9txhNyBOK2W=fgEabv3vXBscD1MNX0dyk6-OV7yCzD291Q@mail.gmail.com>
Date: Wed, 19 Nov 2025 13:15:43 +1000
From: Dave Airlie <airlied@...il.com>
To: Alexandre Courbot <acourbot@...dia.com>
Cc: John Hubbard <jhubbard@...dia.com>, Timur Tabi <ttabi@...dia.com>, 
	"dakr@...nel.org" <dakr@...nel.org>, "lossin@...nel.org" <lossin@...nel.org>, 
	"a.hindborg@...nel.org" <a.hindborg@...nel.org>, "boqun.feng@...il.com" <boqun.feng@...il.com>, 
	"aliceryhl@...gle.com" <aliceryhl@...gle.com>, Zhi Wang <zhiw@...dia.com>, 
	"simona@...ll.ch" <simona@...ll.ch>, "alex.gaynor@...il.com" <alex.gaynor@...il.com>, 
	"ojeda@...nel.org" <ojeda@...nel.org>, "tmgross@...ch.edu" <tmgross@...ch.edu>, 
	"nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>, 
	"bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>, Edwin Peer <epeer@...dia.com>, 
	Joel Fernandes <joelagnelf@...dia.com>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>, 
	"gary@...yguo.net" <gary@...yguo.net>, Alistair Popple <apopple@...dia.com>, 
	Nouveau <nouveau-bounces@...ts.freedesktop.org>
Subject: Re: [PATCH 3/6] gpu: nova-core: Blackwell: basic GPU identification

On Wed, 19 Nov 2025 at 12:46, Alexandre Courbot <acourbot@...dia.com> wrote:
>
> On Wed Nov 19, 2025 at 10:46 AM JST, John Hubbard wrote:
> > On 11/6/25 2:24 PM, John Hubbard wrote:
> >> On 11/6/25 6:44 AM, Timur Tabi wrote:
> >>> On Wed, 2025-11-05 at 19:54 -0800, John Hubbard wrote:
> >>>>       let hal = match chipset {
> >>>> -        GA102 | GA103 | GA104 | GA106 | GA107 | GH100 | AD102 | AD103 | AD104 | AD106 | AD107
> >>>> => {
> >>>> +        GA102 | GA103 | GA104 | GA106 | GA107 | GH100 | AD102 | AD103 | AD104 | AD106 | AD107
> >>>> +        | GB100 | GB102 | GB202 | GB203 | GB205 | GB206 | GB207 => {
> >>>>               KBox::new(ga102::Ga102::<E>::new(), GFP_KERNEL)? as KBox<dyn FalconHal<E>>
> >>>>           }
> >>>
> >>> Maybe combine patches 2 and 3?  Also, maybe this should be a range check, instead of listing
> >>> every since version?  It seems like everything past GA100 uses the GA102 HAL.
> >>>
> >>
> >> Sure, I can combine the patches.
> >>
> >> I'm not sure why I've been wary of using ranges for these arch's.
> >> I'll try it out.
> >
> > Now I know. :)  Unlike C, Rust does *not* like it when we try to
> > treat enums as integers. Casting or other (messier) approaches are
> > required, and in no case is the end result a more readable on-screen
> > experience. At least not so far.
> >
> > It is possible to mix in Architecture (Turing, Ampere, etc) checks,
> > but I'm not sure that is worth the additional clutter.
> >
> > Maybe let's just do the long lists of chipsets for now...?
>
> Yeah, I've hit this issue as well. The compiler might remove that
> limitation in the future, or maybe we can craft a `chipset_range!()`
> macro that hides the messy casting, but this exhaustive listing also has
> the benefit of forcing us to consider every critical site whenever we
> support a new chipset so I'm actually not too bothered by it.

I wrote some macros in my nova-core-experiments, had
chipset_before/after/range I think

Dave.