linux-kernel - Re: [PATCH V4 12/17] cxl/pmem: Preserve region information into nd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <727222a0-6b16-46a9-854f-61fd00f729f9@intel.com>
Date: Wed, 19 Nov 2025 15:00:46 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Neeraj Kumar <s.neeraj@...sung.com>, linux-cxl@...r.kernel.org,
 nvdimm@...ts.linux.dev, linux-kernel@...r.kernel.org, gost.dev@...sung.com
Cc: a.manzanares@...sung.com, vishak.g@...sung.com, neeraj.kernel@...il.com
Subject: Re: [PATCH V4 12/17] cxl/pmem: Preserve region information into
 nd_set



On 11/19/25 12:52 AM, Neeraj Kumar wrote:
> Save region information stored in cxlr to nd_set during
> cxl_pmem_region_probe in nd_set. This saved region information is being
> stored into LSA, which will be used for cxl region persistence
> 
> Signed-off-by: Neeraj Kumar <s.neeraj@...sung.com>

Reviewed-by: Dave Jiang <dave.jiang@...el.com>

> ---
>  drivers/cxl/pmem.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/cxl/pmem.c b/drivers/cxl/pmem.c
> index e197883690ef..a6eba3572090 100644
> --- a/drivers/cxl/pmem.c
> +++ b/drivers/cxl/pmem.c
> @@ -377,6 +377,7 @@ static int cxl_pmem_region_probe(struct device *dev)
>  	struct nd_mapping_desc mappings[CXL_DECODER_MAX_INTERLEAVE];
>  	struct cxl_pmem_region *cxlr_pmem = to_cxl_pmem_region(dev);
>  	struct cxl_region *cxlr = cxlr_pmem->cxlr;
> +	struct cxl_region_params *p = &cxlr->params;
>  	struct cxl_nvdimm_bridge *cxl_nvb = cxlr->cxl_nvb;
>  	struct cxl_pmem_region_info *info = NULL;
>  	struct nd_interleave_set *nd_set;
> @@ -465,12 +466,12 @@ static int cxl_pmem_region_probe(struct device *dev)
>  	ndr_desc.num_mappings = cxlr_pmem->nr_mappings;
>  	ndr_desc.mapping = mappings;
>  
> -	/*
> -	 * TODO enable CXL labels which skip the need for 'interleave-set cookie'
> -	 */
> -	nd_set->cookie1 =
> -		nd_fletcher64(info, sizeof(*info) * cxlr_pmem->nr_mappings, 0);
> -	nd_set->cookie2 = nd_set->cookie1;
> +	nd_set->uuid = p->uuid;
> +	nd_set->interleave_ways = p->interleave_ways;
> +	nd_set->interleave_granularity = p->interleave_granularity;
> +	nd_set->res = p->res;
> +	nd_set->nr_targets = p->nr_targets;
> +
>  	ndr_desc.nd_set = nd_set;
>  
>  	cxlr_pmem->nd_region =