linux-kernel - Re: [PATCH net-next 04/13] ipvlan: Support IPv6 in macnat mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202511191026.AhVx4Zqc-lkp@intel.com>
Date: Wed, 19 Nov 2025 11:25:07 +0800
From: kernel test robot <lkp@...el.com>
To: Dmitry Skorodumov <skorodumov.dmitry@...wei.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, andrey.bokhanko@...wei.com,
	edumazet@...gle.com,
	Dmitry Skorodumov <skorodumov.dmitry@...wei.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 04/13] ipvlan: Support IPv6 in macnat mode.

Hi Dmitry,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Dmitry-Skorodumov/ipvlan-Support-MACNAT-mode/20251118-180814
base:   net-next/main
patch link:    https://lore.kernel.org/r/20251118100046.2944392-5-skorodumov.dmitry%40huawei.com
patch subject: [PATCH net-next 04/13] ipvlan: Support IPv6 in macnat mode.
config: sh-allyesconfig (https://download.01.org/0day-ci/archive/20251119/202511191026.AhVx4Zqc-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251119/202511191026.AhVx4Zqc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511191026.AhVx4Zqc-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/ipvlan/ipvlan_core.c: In function 'ipvlan_macnat_xmit_phydev':
>> drivers/net/ipvlan/ipvlan_core.c:343:25: warning: variable 'orig_skb' set but not used [-Wunused-but-set-variable]
     343 |         struct sk_buff *orig_skb = skb;
         |                         ^~~~~~~~


vim +/orig_skb +343 drivers/net/ipvlan/ipvlan_core.c

e9103e24d10046 Dmitry Skorodumov 2025-11-18  337  
26dcd46025738d Dmitry Skorodumov 2025-11-18  338  static int ipvlan_macnat_xmit_phydev(struct ipvl_port *port,
26dcd46025738d Dmitry Skorodumov 2025-11-18  339  				     struct sk_buff *skb,
26dcd46025738d Dmitry Skorodumov 2025-11-18  340  				     bool lyr3h_valid,
26dcd46025738d Dmitry Skorodumov 2025-11-18  341  				     void *lyr3h, int addr_type)
26dcd46025738d Dmitry Skorodumov 2025-11-18  342  {
26dcd46025738d Dmitry Skorodumov 2025-11-18 @343  	struct sk_buff *orig_skb = skb;
26dcd46025738d Dmitry Skorodumov 2025-11-18  344  
26dcd46025738d Dmitry Skorodumov 2025-11-18  345  	skb = skb_unshare(skb, GFP_ATOMIC);
26dcd46025738d Dmitry Skorodumov 2025-11-18  346  	if (!skb)
26dcd46025738d Dmitry Skorodumov 2025-11-18  347  		return NET_XMIT_DROP;
26dcd46025738d Dmitry Skorodumov 2025-11-18  348  
26dcd46025738d Dmitry Skorodumov 2025-11-18  349  	/* Use eth-addr of main as source. */
26dcd46025738d Dmitry Skorodumov 2025-11-18  350  	skb_reset_mac_header(skb);
26dcd46025738d Dmitry Skorodumov 2025-11-18  351  	ether_addr_copy(skb_eth_hdr(skb)->h_source, port->dev->dev_addr);
26dcd46025738d Dmitry Skorodumov 2025-11-18  352  
26dcd46025738d Dmitry Skorodumov 2025-11-18  353  	if (!lyr3h_valid) {
26dcd46025738d Dmitry Skorodumov 2025-11-18  354  		lyr3h = ipvlan_get_L3_hdr(port, skb, &addr_type);
26dcd46025738d Dmitry Skorodumov 2025-11-18  355  		orig_skb = skb; /* no need to reparse */
26dcd46025738d Dmitry Skorodumov 2025-11-18  356  	}
e9103e24d10046 Dmitry Skorodumov 2025-11-18  357  	if (!lyr3h)
e9103e24d10046 Dmitry Skorodumov 2025-11-18  358  		addr_type = -1;
e9103e24d10046 Dmitry Skorodumov 2025-11-18  359  	else if (addr_type == IPVL_ARP)
e9103e24d10046 Dmitry Skorodumov 2025-11-18  360  		ipvlan_macnat_patch_tx_arp(port, skb);
e9103e24d10046 Dmitry Skorodumov 2025-11-18  361  	else if (addr_type == IPVL_ICMPV6 || addr_type == IPVL_IPV6)
e9103e24d10046 Dmitry Skorodumov 2025-11-18  362  		ipvlan_macnat_patch_tx_ipv6(port, skb);
26dcd46025738d Dmitry Skorodumov 2025-11-18  363  
26dcd46025738d Dmitry Skorodumov 2025-11-18  364  	skb->dev = port->dev;
26dcd46025738d Dmitry Skorodumov 2025-11-18  365  	return dev_queue_xmit(skb);
26dcd46025738d Dmitry Skorodumov 2025-11-18  366  }
26dcd46025738d Dmitry Skorodumov 2025-11-18  367  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki