linux-kernel - Re: [PATCH net-next 14/15] net: dsa: sja1105: replace mdiobus-pcs with xpcs-plat driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251118164130.4e107c93@kernel.org>
Date: Tue, 18 Nov 2025 16:41:30 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit
 <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org, Serge Semin
 <fancer.lancer@...il.com>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Herve Codina
 <herve.codina@...tlin.com>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 devicetree@...r.kernel.org
Subject: Re: [PATCH net-next 14/15] net: dsa: sja1105: replace mdiobus-pcs
 with xpcs-plat driver

On Tue, 18 Nov 2025 21:05:29 +0200 Vladimir Oltean wrote:
> +static bool sja1105_child_node_exists(struct device_node *node,
> +				      const char *name,
> +				      const struct resource *res)
> +{
> +	struct device_node *child = of_get_child_by_name(node, name);
> +	u32 reg[2];
> +
> +	for_each_child_of_node(node, child) {
> +		if (!of_node_name_eq(child, name))
> +			continue;
> +
> +		if (of_property_read_u32_array(child, "reg", reg, ARRAY_SIZE(reg)))
> +			continue;
> +
> +		if (reg[0] == res->start && reg[1] == resource_size(res))
> +			return true;

coccicheck says you're likely leaking the reference on the child here

> +	}
> +
> +	return false;
> +}
-- 
pw-bot: cr