linux-kernel - Re: [PATCH 2/2] ocfs2: Replace deprecated strcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee0a75f2-6090-4dd9-8a95-575fdd859dc3@linux.alibaba.com>
Date: Wed, 19 Nov 2025 13:33:14 +0800
From: Joseph Qi <joseph.qi@...ux.alibaba.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>, Mark Fasheh <mark@...heh.com>,
 Joel Becker <jlbec@...lplan.org>, akpm <akpm@...ux-foundation.org>
Cc: ocfs2-devel@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ocfs2: Replace deprecated strcpy with strscpy



On 2025/11/19 02:53, Thorsten Blum wrote:
> strcpy() has been deprecated [1] because it performs no bounds checking
> on the destination buffer, which can lead to buffer overflows. Replace
> it with the safer strscpy(), and copy directly into '->rf_signature'
> instead of using the start of the struct as the destination buffer.
> 
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Looks fine.
Reviewed-by: Joseph Qi <joseph.qi@...ux.alibaba.com>

> ---
>  fs/ocfs2/refcounttree.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c
> index 267b50e8e42e..c92e0ea85bca 100644
> --- a/fs/ocfs2/refcounttree.c
> +++ b/fs/ocfs2/refcounttree.c
> @@ -34,6 +34,7 @@
>  #include <linux/pagevec.h>
>  #include <linux/swap.h>
>  #include <linux/security.h>
> +#include <linux/string.h>
>  #include <linux/fsnotify.h>
>  #include <linux/quotaops.h>
>  #include <linux/namei.h>
> @@ -621,7 +622,7 @@ static int ocfs2_create_refcount_tree(struct inode *inode,
>  	/* Initialize ocfs2_refcount_block. */
>  	rb = (struct ocfs2_refcount_block *)new_bh->b_data;
>  	memset(rb, 0, inode->i_sb->s_blocksize);
> -	strcpy((void *)rb, OCFS2_REFCOUNT_BLOCK_SIGNATURE);
> +	strscpy(rb->rf_signature, OCFS2_REFCOUNT_BLOCK_SIGNATURE);
>  	rb->rf_suballoc_slot = cpu_to_le16(meta_ac->ac_alloc_slot);
>  	rb->rf_suballoc_loc = cpu_to_le64(suballoc_loc);
>  	rb->rf_suballoc_bit = cpu_to_le16(suballoc_bit_start);
> @@ -1562,7 +1563,7 @@ static int ocfs2_new_leaf_refcount_block(handle_t *handle,
>  	/* Initialize ocfs2_refcount_block. */
>  	new_rb = (struct ocfs2_refcount_block *)new_bh->b_data;
>  	memset(new_rb, 0, sb->s_blocksize);
> -	strcpy((void *)new_rb, OCFS2_REFCOUNT_BLOCK_SIGNATURE);
> +	strscpy(new_rb->rf_signature, OCFS2_REFCOUNT_BLOCK_SIGNATURE);
>  	new_rb->rf_suballoc_slot = cpu_to_le16(meta_ac->ac_alloc_slot);
>  	new_rb->rf_suballoc_loc = cpu_to_le64(suballoc_loc);
>  	new_rb->rf_suballoc_bit = cpu_to_le16(suballoc_bit_start);