linux-kernel - Re: [v2, net-next 09/12] bng_en: Add ethtool link settings and capabilities support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANXQDtb5XuLKOOorCMYDUpVz6aFuQgvmQZ4pS6RJGkAgeM8n1A@mail.gmail.com>
Date: Wed, 19 Nov 2025 11:38:27 +0530
From: Bhargava Chenna Marreddy <bhargava.marreddy@...adcom.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	michael.chan@...adcom.com, pavan.chebbi@...adcom.com, 
	vsrama-krishna.nemani@...adcom.com, vikas.gupta@...adcom.com, 
	Rajashekar Hudumula <rajashekar.hudumula@...adcom.com>
Subject: Re: [v2, net-next 09/12] bng_en: Add ethtool link settings and
 capabilities support

On Sun, Nov 16, 2025 at 2:38 AM Andrew Lunn <andrew@...n.ch> wrote:
>
> > +
> > +     if (!(bd->phy_flags & BNGE_PHY_FL_NO_PAUSE)) {
> > +             linkmode_set_bit(ETHTOOL_LINK_MODE_Pause_BIT,
> > +                              lk_ksettings->link_modes.supported);
> > +             linkmode_set_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
> > +                              lk_ksettings->link_modes.supported);
> > +     }
> > +
> > +     if (link_info->support_auto_speeds || link_info->support_auto_speeds2 ||
> > +         link_info->support_pam4_auto_speeds)
> > +             linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,
> > +                              lk_ksettings->link_modes.supported);
>
> autoneg is more than speed. In fact, 1000BaseX only works are 1G, no
> link speed negotiation, but you can negotiate pause. Do any of the
> link modes you support work like this?

All the speeds we support can be auto-negotiated. We don't see any
cases like 1000Base-X.
Do you see any issue with the above setting autoneg?

>
> > +     /* Note ETHTOOL_LINK_MODE_10baseT_Half_BIT == 0 is a legal Linux
> > +      * link mode, but since no such devices exist
>
> 10BaseT Half devices definitely do exist, and there are actually more
> appearing in the automotive field.

Our devices don't support 10baseT_Half, will fix the comment.

Thanks,
Bhargava Marreddy

>
>
>     Andrew
>
> ---
> pw-bot: cr

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5496 bytes)