linux-kernel - Re: [PATCH v9 13/22] KVM: VMX: Virtualize FRED nested exception tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aR1puS6Gvp/JqZxd@intel.com>
Date: Wed, 19 Nov 2025 14:54:49 +0800
From: Chao Gao <chao.gao@...el.com>
To: "Xin Li (Intel)" <xin@...or.com>
CC: <linux-kernel@...r.kernel.org>, <kvm@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <pbonzini@...hat.com>, <seanjc@...gle.com>,
	<corbet@....net>, <tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
	<dave.hansen@...ux.intel.com>, <x86@...nel.org>, <hpa@...or.com>,
	<luto@...nel.org>, <peterz@...radead.org>, <andrew.cooper3@...rix.com>,
	<hch@...radead.org>, <sohil.mehta@...el.com>
Subject: Re: [PATCH v9 13/22] KVM: VMX: Virtualize FRED nested exception
 tracking

On Sun, Oct 26, 2025 at 01:19:01PM -0700, Xin Li (Intel) wrote:
>From: Xin Li <xin3.li@...el.com>
>
>Set the VMX nested exception bit in VM-entry interruption information
>field when injecting a nested exception using FRED event delivery to
>ensure:
>  1) A nested exception is injected on a correct stack level.
>  2) The nested bit defined in FRED stack frame is set.
>
>The event stack level used by FRED event delivery depends on whether
>the event was a nested exception encountered during delivery of an
>earlier event, because a nested exception is "regarded" as happening
>on ring 0.  E.g., when #PF is configured to use stack level 1 in
>IA32_FRED_STKLVLS MSR:
>  - nested #PF will be delivered on the stack pointed by IA32_FRED_RSP1
>    MSR when encountered in ring 3 and ring 0.
>  - normal #PF will be delivered on the stack pointed by IA32_FRED_RSP0
>    MSR when encountered in ring 3.
>
>The VMX nested-exception support ensures a correct event stack level is
>chosen when a VM entry injects a nested exception.
>
>Signed-off-by: Xin Li <xin3.li@...el.com>
>[ Sean: reworked kvm_requeue_exception() to simply the code changes ]
>Signed-off-by: Sean Christopherson <seanjc@...gle.com>
>Signed-off-by: Xin Li (Intel) <xin@...or.com>
>Tested-by: Shan Kang <shan.kang@...el.com>
>Tested-by: Xuelian Guo <xuelian.guo@...el.com>

Reviewed-by: Chao Gao <chao.gao@...el.com>