linux-kernel - Re: [PATCH 1/2] md: warn about updating super block failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5067f181-92b8-8f9c-ce71-477bc4466e6d@huaweicloud.com>
Date: Wed, 19 Nov 2025 15:06:03 +0800
From: Li Nan <linan666@...weicloud.com>
To: Yu Kuai <yukuai@...as.com>, linux-raid@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] md: warn about updating super block failure



在 2025/11/17 16:55, Yu Kuai 写道:
> Many personalities will handle IO error from daemon thread(like raid1d,
> raid10d, raid5d), and sb will require to be clean before hanlding these
> failed IO. However update sb can fail, for example array is broken by
> IO failure, or user config sysfs api array_state.
> 
> This patch adds warning if updating sb failed first, in case this will
> be related to IO hang.
> 
> Signed-off-by: Yu Kuai <yukuai@...as.com>
> ---
>   drivers/md/md.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 7b5c5967568f..345b1e623aba 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -2788,6 +2788,7 @@ void md_update_sb(struct mddev *mddev, int force_change)
>   	if (!md_is_rdwr(mddev)) {
>   		if (force_change)
>   			set_bit(MD_SB_CHANGE_DEVS, &mddev->sb_flags);
> +		pr_err("%s: can't update sb for read-only array %s\n", __func__, mdname(mddev));
>   		return;
>   	}
>   

LGTM

Reviewed-by: Li Nan <linan122@...wei.com>
-- 
Thanks,
Nan