linux-kernel - Re: [PATCH v2] overlayfs: fix uninitialized pointers with free attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c11915eda500f12ed56dd77875c96f53c496fbf.camel@gmail.com>
Date: Wed, 19 Nov 2025 12:43:18 +0530
From: ally heev <allyheev@...il.com>
To: Amir Goldstein <amir73il@...il.com>, Christian Brauner
 <brauner@...nel.org>
Cc: Miklos Szeredi <miklos@...redi.hu>, linux-unionfs@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH v2] overlayfs: fix uninitialized pointers with free
 attribute

On Sat, 2025-11-15 at 14:59 +0100, Amir Goldstein wrote:
[...]
> Christian,
> 
> Mind picking this one?
> 
> Thanks,
> Amir.
> 

We might want to wait. There's an ongoing discussion going on about
this rule
https://lore.kernel.org/lkml/58fd478f408a34b578ee8d949c5c4b4da4d4f41d.camel@HansenPartnership.com/.
Mostly likely, I might have to revert to v1 of this patch
 
> >  fs/overlayfs/params.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c
> > index 63b7346c5ee1c127a9c33b12c3704aa035ff88cf..37086f73ac3ecfcd1c09ae6eccbb69723006e031 100644
> > --- a/fs/overlayfs/params.c
> > +++ b/fs/overlayfs/params.c
> > @@ -448,7 +448,7 @@ static int ovl_parse_layer(struct fs_context *fc, struct fs_parameter *param,
> >                 err = ovl_do_parse_layer(fc, param->string, &layer_path, layer);
> >                 break;
> >         case fs_value_is_file: {
> > -               char *buf __free(kfree);
> > +               char *buf __free(kfree) = NULL;
> >                 char *layer_name;
> > 
> >                 buf = kmalloc(PATH_MAX, GFP_KERNEL_ACCOUNT);
> > 
> > ---
> > base-commit: c9cfc122f03711a5124b4aafab3211cf4d35a2ac
> > change-id: 20251105-aheev-uninitialized-free-attr-overlayfs-6873964429e0
> > 
> > Best regards,
> > --
> > Ally Heev <allyheev@...il.com>
> > 

Thanks,
Ally