linux-kernel - Re: [PATCH] fbdev/tridentfb: replace printk() with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABPJ0vjy1ccb4DCd5Q1B=LQPMdpAQN+hhWd39tk9y6TbepZoSw@mail.gmail.com>
Date: Wed, 19 Nov 2025 08:16:58 +0100
From: Javier Garcia <rampxxxx@...il.com>
To: deller@....de
Cc: linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH] fbdev/tridentfb: replace printk() with dev_*() in probe

Hi Deller,

Any comments on this patch?,

Thanks!

---
Javier Garcia

On Sat, 15 Nov 2025 at 13:57, Javier Garcia <rampxxxx@...il.com> wrote:
>
> - Replace in `trident_pc_probe()` printk by dev_* fn's
> - Delete the prefix `tridentfb:` from msg strings, not needed now.
>
> Signed-off-by: Javier Garcia <rampxxxx@...il.com>
> ---
>  drivers/video/fbdev/tridentfb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c
> index 516cf2a18757..17b7253b8fbe 100644
> --- a/drivers/video/fbdev/tridentfb.c
> +++ b/drivers/video/fbdev/tridentfb.c
> @@ -1631,7 +1631,7 @@ static int trident_pci_probe(struct pci_dev *dev,
>         }
>
>         if (noaccel) {
> -               printk(KERN_DEBUG "disabling acceleration\n");
> +               dev_dbg(&dev->dev, "disabling acceleration\n");
>                 info->flags |= FBINFO_HWACCEL_DISABLED;
>                 info->pixmap.scan_align = 1;
>         }
> @@ -1693,7 +1693,7 @@ static int trident_pci_probe(struct pci_dev *dev,
>         info->var.activate |= FB_ACTIVATE_NOW;
>         info->device = &dev->dev;
>         if (register_framebuffer(info) < 0) {
> -               printk(KERN_ERR "tridentfb: could not register framebuffer\n");
> +               dev_err(&dev->dev, "could not register framebuffer\n");
>                 fb_dealloc_cmap(&info->cmap);
>                 err = -EINVAL;
>                 goto out_unmap2;
> --
> 2.50.1
>