linux-kernel - Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3 and 3S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d5ed2bc-038c-0808-56f3-411652b5ed6d@manjaro.org>
Date: Wed, 19 Nov 2025 08:28:43 +0100
From: "Dragan Simic" <dsimic@...jaro.org>
To: "Michael Opdenacker" <michael.opdenacker@...tcommit.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, heiko@...ech.de, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3 and 3S

On Wednesday, November 19, 2025 08:25 CET, Michael Opdenacker <michael.opdenacker@...tcommit.com> wrote:
> > This should let us keep the "asus,rk3566-tinker-board-3" compatible
> > in the new rk3566-tinker-board-3s.dts board dts while satisfying the
> > validation properly:
> >
> >    - description: Asus Tinker Board 3/3S
> >      items:
> >      - enum:
> >          - asus,rk3566-tinker-board-3s
> >      - const: asus,rk3566-tinker-board-3
> >      - const: rockchip,rk3566
> >
> > I'm quite busy at the moment, hence my delayed response, and I also
> > apologize for not running the checks on the above-proposed solution,
> > but I think it should work as expected.
> 
> I actually already tried this, but it doesn't pass "make dtbs_check":
> 
> arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dtb: / 
> (asus,rk3566-tinker-board-3): compatible: 'oneOf' conditional failed, 
> one must be fixed:
>      ['asus,rk3566-tinker-board-3', 'rockchip,rk3566'] is too short
> 
> The "enum" statement seems to mean that there is at least one of the 
> items, which is not the case for rk3566-tinker-board-3.dts that doesn't 
> have it.
> 
> So, my V3 seems like the way to go if we don't want to duplicate entries 
> in rockchip.yaml.

I see, thanks for the clarification.  Then the v3 is the way to go.