linux-kernel - Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b98e53ce-9c8c-c505-6097-0d22d0416e8e@manjaro.org>
Date: Wed, 19 Nov 2025 08:40:09 +0100
From: "Dragan Simic" <dsimic@...jaro.org>
To: "Krzysztof Kozlowski" <krzk@...nel.org>
Cc: "Michael Opdenacker" <michael.opdenacker@...tcommit.com>, "Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>, "Heiko Stuebner" <heiko@...ech.de>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

On Wednesday, November 19, 2025 08:31 CET, Krzysztof Kozlowski <krzk@...nel.org> wrote:
> On 19/11/2025 08:23, Dragan Simic wrote:
> > On Wednesday, November 19, 2025 08:09 CET, Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >> On 19/11/2025 08:00, Dragan Simic wrote:
> >>> On Tuesday, November 18, 2025 16:56 CET, Michael Opdenacker <michael.opdenacker@...tcommit.com> wrote:
> >>>> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
> >>>> which are SBCs based on the Rockchip 3566 SoC.
> >>>>
> >>>> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
> >>>> and a "mask ROM" DIP switch to the "3" version.
> >>>>
> >>>> [1] https://tinker-board.asus.com/series/tinker-board-3.html
> >>>> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
> >>>>
> >>>> Signed-off-by: Michael Opdenacker <michael.opdenacker@...tcommit.com>
> >>>>
> >>>> ---
> >>>>
> >>>> Changes in V3:
> >>>>
> >>>> - Remove this Acked-by as the binding code changed substantially:
> >>>>   Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >>>> ---
> >>>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
> >>>>  1 file changed, 7 insertions(+)
> >>>>
> >>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >>>> index 6aceaa8acbb2..800c11323a4f 100644
> >>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> >>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >>>> @@ -86,6 +86,13 @@ properties:
> >>>>            - const: asus,rk3288-tinker-s
> >>>>            - const: rockchip,rk3288
> >>>>  
> >>>> +      - description: Asus Tinker Board 3/3S
> >>>> +        items:
> >>>> +          - enum:
> >>>> +              - asus,rk3566-tinker-board-3
> >>>> +              - asus,rk3566-tinker-board-3s
> >>>> +          - const: rockchip,rk3566
> >>>> +
> >>>>        - description: Beelink A1
> >>>>          items:
> >>>>            - const: azw,beelink-a1
> >>>
> >>> Please see my delayed response in the v2. [1]  I think that would be
> >>> a better approach.
> >>>
> >>> [1] https://lore.kernel.org/linux-rockchip/3c96ee6b-dca7-1a0a-792b-f8c165ec997d@manjaro.org/
> >>
> >> Your reviews are not helpful. You nitpick irrelevant things and propose
> >> solutions which later reverse leading to wasted effort on contributors side.
> >>
> >> Michael implemented what you asked here:
> >>
> >> https://lore.kernel.org/linux-rockchip/e4cd11d0-463c-e707-5110-6b92899b1ba3@manjaro.org/
> > 
> > Not exactly, because I didn't ask for any compatibles to be removed
> > from the new board dts files.
> 
> Read your answer again. You wanted ENTIRE bindings, to be like this:
> 
>      - description: Asus Tinker Board 3/3S
>        items:
>          - enum:
> 	   - asus,rk3566-tinker-board-3
>            - asus,rk3566-tinker-board-3s
>          - const: rockchip,rk3566
> 
> (skipping obvious indentation fixup)
> There are exactly like this.
> 
> > 
> > In this case, we could also say that it was Michael's fault not to
> > give enough time for the reviewers to respond.
> 
> Michael implemented EXACTLY what you asked. Now, you ask to change it to
> what Michael did BEFORE.

Not really, because it wasn't some kind of a request from my side,
but merely a suggestion that was intended to be discussed further
so the best possible solution is reached before v3 is submitted.

> Your reviews are completely irresponsible and incorrect.

Calling my reviews irresponsible hurts me a lot, really, but I'm
unfortunately already used to hear hurtful things from your side.