linux-kernel - Re: [PATCH v2] tracing: Show the tracer options in boot-time created instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251119173137.c7e489c079e942eedd48b249@kernel.org>
Date: Wed, 19 Nov 2025 17:31:37 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Masami Hiramatsu (Google) <mhiramat@...nel.org>
Cc: Steven Rostedt <rostedt@...dmis.org>, Mark Rutland
 <mark.rutland@....com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tracing: Show the tracer options in boot-time
 created instance

On Wed, 19 Nov 2025 13:39:42 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 8ae95800592d..4a6784057855 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -10231,11 +10231,16 @@ static __init int __update_tracer_options(struct trace_array *tr)
> >  	return ret;
> >  }
> >  
> > -static __init void update_tracer_options(struct trace_array *tr)
> > +static __init void update_tracer_options(void)
> >  {
> > +	struct trace_array *tr;
> > +
> >  	guard(mutex)(&trace_types_lock);
> > +
> > +	list_for_each_entry(tr, &ftrace_trace_arrays, list)
> > +		__update_tracer_options(tr);
> > +
> >  	tracer_options_updated = true;

Oops, I misunderstood this flag. This should be set *before* calling
__update_tracer_options(). Not updated.

Thanks,

-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>