linux-kernel - Re: [PATCH] phy: qcom: m31-eusb2: Update init sequence to set PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bbf1fc3d-228a-42ad-97ee-8a03003b08b5@linaro.org>
Date: Wed, 19 Nov 2025 09:42:25 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Wesley Cheng <wesley.cheng@....qualcomm.com>, kishon@...nel.org,
 vkoul@...nel.org
Cc: linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Ronak Raheja <ronak.raheja@....qualcomm.com>
Subject: Re: [PATCH] phy: qcom: m31-eusb2: Update init sequence to set
 PHY_ENABLE

On 9/20/25 05:21, Wesley Cheng wrote:
> From: Ronak Raheja <ronak.raheja@....qualcomm.com>
> 
> Certain platforms may not have the PHY_ENABLE bit set on power on reset.
> Update the current sequence to explicitly write to enable the PHY_ENABLE
> bit.  This ensures that regardless of the platform, the PHY is properly
> enabled.
> 
> Signed-off-by: Ronak Raheja <ronak.raheja@....qualcomm.com>
> Signed-off-by: Wesley Cheng <wesley.cheng@....qualcomm.com>
> ---
>   drivers/phy/qualcomm/phy-qcom-m31-eusb2.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> index bf32572566c4..fbf5e999ca7a 100644
> --- a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> +++ b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> @@ -25,6 +25,7 @@
>   #define POR				BIT(1)
>   
>   #define USB_PHY_HS_PHY_CTRL_COMMON0	(0x54)
> +#define PHY_ENABLE			BIT(0)
>   #define SIDDQ_SEL			BIT(1)
>   #define SIDDQ				BIT(2)
>   #define FSEL				GENMASK(6, 4)
> @@ -81,6 +82,7 @@ struct m31_eusb2_priv_data {
>   static const struct m31_phy_tbl_entry m31_eusb2_setup_tbl[] = {
>   	M31_EUSB_PHY_INIT_CFG(USB_PHY_CFG0, UTMI_PHY_CMN_CTRL_OVERRIDE_EN, 1),
>   	M31_EUSB_PHY_INIT_CFG(USB_PHY_UTMI_CTRL5, POR, 1),
> +	M31_EUSB_PHY_INIT_CFG(USB_PHY_HS_PHY_CTRL_COMMON0, PHY_ENABLE, 1),
>   	M31_EUSB_PHY_INIT_CFG(USB_PHY_CFG1, PLL_EN, 1),
>   	M31_EUSB_PHY_INIT_CFG(USB_PHY_FSEL_SEL, FSEL_SEL, 1),
>   };

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>