linux-kernel - RE: [PATCH v3 net] net: phylink: add missing supported link modes for the fixed-link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8510BA569EB34E26E1A499BB88D7A@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Wed, 19 Nov 2025 01:22:17 +0000
From: Wei Fang <wei.fang@....com>
To: Russell King <linux@...linux.org.uk>, Andrew Lunn <andrew@...n.ch>
CC: "hkallweit1@...il.com" <hkallweit1@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"eric@...int.com" <eric@...int.com>, "maxime.chevallier@...tlin.com"
	<maxime.chevallier@...tlin.com>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 net] net: phylink: add missing supported link modes for
 the fixed-link

> On Tue, Nov 18, 2025 at 03:00:00PM +0100, Andrew Lunn wrote:
> > > > > Fixes: de7d3f87be3c ("net: phylink: Use phy_caps_lookup for fixed-link
> > > > > configuration")
> > > > > Signed-off-by: Wei Fang <wei.fang@....com>
> > > > > Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> > > >
> > > > NAK. I give up.
> > > >
> > >
> > > Sorry, could you please tell me what the reason is?
> >
> > I think Russell is referring to the commit message, and how you only
> > quoted a little section of his explanation. There is no limit to
> > commit messages, they don't need to be short. It is actually better if
> > they are long. So you could use his whole explanation. And then you
> > don't need the link.
> 
> Worse than that. I gave my reviewed-by, which seems to have been a waste
> of time.
> 

I'm sorry, I was in a rush to send out the v3 patch, and I hadn't received
your Reviewed-by tag at that time, so the tag was not added. When I saw
that you gave the Review-by in v2, I realized that I could no longer add it
to v3, so I replied that I had sent v3, hoping that you could resend your
Reviewed-by tag.

If you don't mind, I will refine the commit message as Andrew suggested
and add your Revived-by tag from v2 to v4. I apologize again.