linux-kernel - Re: [PATCH v3 3/8] drm/panel: sw43408: Introduce LH546WF1-ED01 panel compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bbc3662c-8622-4667-90d7-02b7d66cad71@ixit.cz>
Date: Wed, 19 Nov 2025 11:20:39 +0100
From: David Heidelberg <david@...t.cz>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Sumit Semwal <sumit.semwal@...aro.org>,
 Casey Connolly <casey.connolly@...aro.org>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <jesszhan0024@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 phodina@...tonmail.com, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 phone-devel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v3 3/8] drm/panel: sw43408: Introduce LH546WF1-ED01 panel
 compatible

On 19/11/2025 08:36, Dmitry Baryshkov wrote:
> On Tue, Nov 18, 2025 at 12:30:38PM +0100, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@...t.cz>
>>
>> The supported panel is LH546WF1-ED01, add compatible and adjust the
>> struct name to reflect that.
>>
>> The standalone compatible lg,sw43408 will continue to work, even thou
>> there are no users yet.
> 
> .. no users _left_ ?

The compatible users wasn't introduced in the first place (the driver is 
written for Pixel 3, but the device-tree didn't got in back then).

[...]

>>   static int sw43408_backlight_update_status(struct backlight_device *bl)
>> @@ -214,7 +214,9 @@ static const struct drm_panel_funcs sw43408_funcs = {
>>   };
>>   
>>   static const struct of_device_id sw43408_of_match[] = {
>> +	/* legacy */
> 
> Nit: I'd read this comment in a way that both entries are legacy. Would
> it be possible to adjust this somehow (e.g. put legacy on the same line
> or extend it, explaining that only lg,sw43408 is legacy).

Sure, I'll inline it.

Thanks
David

> 
>>   	{ .compatible = "lg,sw43408", },
>> +	{ .compatible = "lg,sw43408-lh546wf1-ed01", },
> 
>>   	{ /* sentinel */ }
>>   };
>>   MODULE_DEVICE_TABLE(of, sw43408_of_match);
>>
>> --