| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aR2bazZn8m4EMHdW@smile.fi.intel.com>
Date: Wed, 19 Nov 2025 12:26:51 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Petr Mladek <pmladek@...e.com>
Cc: Corey Minyard <corey@...yard.net>,
Christian König <christian.koenig@....com>,
"Dr. David Alan Gilbert" <linux@...blig.org>,
Alex Deucher <alexander.deucher@....com>,
Thomas Zimmermann <tzimmermann@...e.de>,
Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
Rob Clark <robin.clark@....qualcomm.com>,
Matthew Brost <matthew.brost@...el.com>,
Ulf Hansson <ulf.hansson@...aro.org>,
Aleksandr Loktionov <aleksandr.loktionov@...el.com>,
Vitaly Lifshits <vitaly.lifshits@...el.com>,
Manivannan Sadhasivam <mani@...nel.org>,
Niklas Cassel <cassel@...nel.org>, Calvin Owens <calvin@...nvd.org>,
Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
Sagi Maimon <maimon.sagi@...il.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Karan Tilak Kumar <kartilak@...co.com>,
Hans Verkuil <hverkuil+cisco@...nel.org>,
Casey Schaufler <casey@...aufler-ca.com>,
Steven Rostedt <rostedt@...dmis.org>,
Viacheslav Dubeyko <Slava.Dubeyko@....com>,
Max Kellermann <max.kellermann@...os.com>,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
openipmi-developer@...ts.sourceforge.net,
linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linaro-mm-sig@...ts.linaro.org, amd-gfx@...ts.freedesktop.org,
linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org,
intel-xe@...ts.freedesktop.org, linux-mmc@...r.kernel.org,
netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
linux-pci@...r.kernel.org, linux-s390@...r.kernel.org,
linux-scsi@...r.kernel.org, linux-staging@...ts.linux.dev,
ceph-devel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
Rasmus Villemoes <linux@...musvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@...omium.org>,
Jonathan Corbet <corbet@....net>,
Sumit Semwal <sumit.semwal@...aro.org>,
Gustavo Padovan <gustavo@...ovan.org>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Dmitry Baryshkov <lumag@...nel.org>,
Abhinav Kumar <abhinav.kumar@...ux.dev>,
Jessica Zhang <jesszhan0024@...il.com>, Sean Paul <sean@...rly.run>,
Marijn Suijten <marijn.suijten@...ainline.org>,
Konrad Dybcio <konradybcio@...nel.org>,
Lucas De Marchi <lucas.demarchi@...el.com>,
Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@...el.com>,
Vladimir Oltean <olteanv@...il.com>, Andrew Lunn <andrew@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Tony Nguyen <anthony.l.nguyen@...el.com>,
Przemek Kitszel <przemyslaw.kitszel@...el.com>,
Krzysztof Wilczyński <kwilczynski@...nel.org>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Rodolfo Giometti <giometti@...eenne.com>,
Jonathan Lemon <jonathan.lemon@...il.com>,
Richard Cochran <richardcochran@...il.com>,
Stefan Haberland <sth@...ux.ibm.com>,
Jan Hoeppner <hoeppner@...ux.ibm.com>,
Heiko Carstens <hca@...ux.ibm.com>,
Vasily Gorbik <gor@...ux.ibm.com>,
Alexander Gordeev <agordeev@...ux.ibm.com>,
Christian Borntraeger <borntraeger@...ux.ibm.com>,
Sven Schnelle <svens@...ux.ibm.com>,
Satish Kharat <satishkh@...co.com>,
Sesidhar Baddela <sebaddel@...co.com>,
"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Xiubo Li <xiubli@...hat.com>, Ilya Dryomov <idryomov@...il.com>,
Masami Hiramatsu <mhiramat@...nel.org>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v3 19/21] scsi: fnic: Switch to use %ptSp
On Wed, Nov 19, 2025 at 11:08:01AM +0100, Petr Mladek wrote:
> On Thu 2025-11-13 15:32:33, Andy Shevchenko wrote:
> > Use %ptSp instead of open coded variants to print content of
> > struct timespec64 in human readable format.
>
> I was about to commit the changes into printk/linux.git and
> found a mistake during the final double check, see below.
>
> > diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
> > index cdc6b12b1ec2..0a849a195a8e 100644
> > --- a/drivers/scsi/fnic/fnic_trace.c
> > +++ b/drivers/scsi/fnic/fnic_trace.c
> > @@ -215,30 +213,26 @@ int fnic_get_stats_data(struct stats_debug_info *debug,
> > {
> > int len = 0;
> > int buf_size = debug->buf_size;
> > - struct timespec64 val1, val2;
> > + struct timespec64 val, val1, val2;
> > int i = 0;
> >
> > - ktime_get_real_ts64(&val1);
> > + ktime_get_real_ts64(&val);
> > len = scnprintf(debug->debug_buffer + len, buf_size - len,
> > "------------------------------------------\n"
> > "\t\tTime\n"
> > "------------------------------------------\n");
> >
> > + val1 = timespec64_sub(val, stats->stats_timestamps.last_reset_time);
> > + val2 = timespec64_sub(val, stats->stats_timestamps.last_read_time);
> > len += scnprintf(debug->debug_buffer + len, buf_size - len,
> > - "Current time : [%lld:%ld]\n"
> > - "Last stats reset time: [%lld:%09ld]\n"
> > - "Last stats read time: [%lld:%ld]\n"
> > - "delta since last reset: [%lld:%ld]\n"
> > - "delta since last read: [%lld:%ld]\n",
> > - (s64)val1.tv_sec, val1.tv_nsec,
> > - (s64)stats->stats_timestamps.last_reset_time.tv_sec,
> > - stats->stats_timestamps.last_reset_time.tv_nsec,
> > - (s64)stats->stats_timestamps.last_read_time.tv_sec,
> > - stats->stats_timestamps.last_read_time.tv_nsec,
> > - (s64)timespec64_sub(val1, stats->stats_timestamps.last_reset_time).tv_sec,
> > - timespec64_sub(val1, stats->stats_timestamps.last_reset_time).tv_nsec,
> > - (s64)timespec64_sub(val1, stats->stats_timestamps.last_read_time).tv_sec,
> > - timespec64_sub(val1, stats->stats_timestamps.last_read_time).tv_nsec);
> > + "Current time : [%ptSp]\n"
> > + "Last stats reset time: [%ptSp]\n"
> > + "Last stats read time: [%ptSp]\n"
> > + "delta since last reset: [%ptSp]\n"
> > + "delta since last read: [%ptSp]\n",
>
> Both delta times are printed at the end.
>
> > + &val,
> > + &stats->stats_timestamps.last_reset_time, &val1,
> > + &stats->stats_timestamps.last_read_time, &val2);
>
> I think that this should be:
>
> &stats->stats_timestamps.last_reset_time,
> &stats->stats_timestamps.last_read_time,
> &val1, &val2);
>
> > stats->stats_timestamps.last_read_time = val1;
>
> The original code stored the current time in "val1". This should be:
>
> stats->stats_timestamps.last_read_time = val;
>
> > @@ -416,8 +410,8 @@ int fnic_get_stats_data(struct stats_debug_info *debug,
> > jiffies_to_timespec64(stats->misc_stats.last_ack_time, &val2);
>
> Just for record. Another values are stored into @val1 and @val2 at
> this point.
>
> > len += scnprintf(debug->debug_buffer + len, buf_size - len,
> > - "Last ISR time: %llu (%8llu.%09lu)\n"
> > - "Last ACK time: %llu (%8llu.%09lu)\n"
> > + "Last ISR time: %llu (%ptSp)\n"
> > + "Last ACK time: %llu (%ptSp)\n"
> > "Max ISR jiffies: %llu\n"
> > "Max ISR time (ms) (0 denotes < 1 ms): %llu\n"
> > "Corr. work done: %llu\n"
> > @@ -437,10 +431,8 @@ int fnic_get_stats_data(struct stats_debug_info *debug,
> > "Number of rport not ready: %lld\n"
> > "Number of receive frame errors: %lld\n"
> > "Port speed (in Mbps): %lld\n",
> > - (u64)stats->misc_stats.last_isr_time,
> > - (s64)val1.tv_sec, val1.tv_nsec,
> > - (u64)stats->misc_stats.last_ack_time,
> > - (s64)val2.tv_sec, val2.tv_nsec,
> > + (u64)stats->misc_stats.last_isr_time, &val1,
> > + (u64)stats->misc_stats.last_ack_time, &val2,
>
> So, this is correct!
>
> > (u64)atomic64_read(&stats->misc_stats.max_isr_jiffies),
> > (u64)atomic64_read(&stats->misc_stats.max_isr_time_ms),
> > (u64)atomic64_read(&stats->misc_stats.corr_work_done),
>
>
> Now, I think that there is no need to resend the entire huge patchset.
>
> I could either fix this when comitting or commit the rest and
> you could send only this patch for review.
Thank you for the thoroughly done review, I changed that patch between the
versions and the problem is that for printf() specifiers (extensions) we do not
have an automatic type checking. We starve for a GCC plugin for that, yeah...
In any case, if you fold your changes in, I will appreciate that!
Otherwise it's also fine with me to send a patch separately later on.
> PS: All other patches look good. Well, nobody acked 7th patch yet.
> But I think that the change is pretty straightforward and
> we could do it even without an ack.
This is my understanding as well. It changes the output, but that output is
debug anyway. So I don't expect breakage of anything we have an obligation
to keep working.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists