linux-kernel - Re: [PATCH v7 2/6] dt-bindings: mfd: Binding for RTL8231

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqKKpymk_i9c=29Zq0QSzHMU3x0RPWjBMmW84k_5jUe4Jg@mail.gmail.com>
Date: Tue, 18 Nov 2025 19:37:55 -0600
From: Rob Herring <robh@...nel.org>
To: Sander Vanheule <sander@...nheule.net>
Cc: Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Michael Walle <mwalle@...nel.org>, 
	Bartosz Golaszewski <brgl@...ev.pl>, linux-leds@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v7 2/6] dt-bindings: mfd: Binding for RTL8231

On Tue, Nov 18, 2025 at 3:57 PM Sander Vanheule <sander@...nheule.net> wrote:
>
> Hi Rob,
>
> On Tue, 2025-11-18 at 15:28 -0600, Rob Herring wrote:
> > On Mon, Nov 17, 2025 at 3:52 PM Sander Vanheule <sander@...nheule.net> wrote:
> > > +patternProperties:
> > > +  "-pins$":
> > > +    type: object
> > > +    $ref: /schemas/pinctrl/pinmux-node.yaml#
> >
> >          additionalProperties: false
>
> In this case dt_binding_check doesn't recognize input-debounce. The following seems to
> work for the provided example:
>
> -    $ref: /schemas/pinctrl/pinmux-node.yaml#
> +    allOf:
> +      - $ref: /schemas/pinctrl/pincfg-node.yaml#
> +      - $ref: /schemas/pinctrl/pinmux-node.yaml#
> +
> +    additionalProperties: false
>
>
> with this included in the led node properties:
> +      input-debounce: true
>
> If I understand correctly, "unevaluatedProperties: false" (like for the leds binding)
> would allow everything from the referenced pincfg-node and pinmux-node schemas, which is
> more than is actually supported by this device.

Yes, that works too. The first way lets you be explicit about which
referenced properties are used, but either way is fine. If it is only
1 property, then I'd probably go with the first way.

Rob