linux-kernel - Re: [PATCH v4 1/1] cpuset: relax the overlap check for cgroup-v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251119110340.1386752-1-sunshaojie@kylinos.cn>
Date: Wed, 19 Nov 2025 19:03:40 +0800
From: Sun Shaojie <sunshaojie@...inos.cn>
To: chenridong@...weicloud.com
Cc: cgroups@...r.kernel.org,
	hannes@...xchg.org,
	linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	llong@...hat.com,
	mkoutny@...e.com,
	shuah@...nel.org,
	sunshaojie@...inos.cn,
	tj@...nel.org
Subject: Re: [PATCH v4 1/1] cpuset: relax the overlap check for cgroup-v2

Hi, Ridong,

On 2025/11/17 19:37, Chen Ridong wrote:
>On 2025/11/17 18:00, Sun Shaojie wrote:
>> Certainly, this rule applies regardless of whether cs1 or cs2 is exclusive,
>> and the current implementation already handles it this way.
>> The following two cases cover this rule. 
>> "1. If cs1 is exclusive, cs1 and cs2 must be mutually exclusive"
>> "3. If cs2 is exclusive, cs2's allowed CPUs cannot be a subset of cs1's exclusive CPUs"
>> 
>
>I believe this function should return the same result regardless of whether it is called as
>cpus_excl_conflict(A1, B1) or cpus_excl_conflict(B1, A1), which means cs1 and cs2 should be treated
>symmetrically. However, since cs1 and cs2 are handled differently, it is difficult to convince me
>that this implementation is correct.

In patch v5, modifications to the cpus_excl_conflict interface have been 
avoided, along with preventing the following ineffective scenario.

Both A1 and B1 are exclusive, change B1's cpuset.cpus, avoid A1 becoming 
non-exclusive.

Looking forward to your feedback on patch v5.
patch v5 : https://lore.kernel.org/cgroups/20251119105749.1385946-1-sunshaojie@kylinos.cn/

Thanks,
Sun Shaojie