linux-kernel - Re: [PATCH v5 1/2] dt-bindings: fpga: stratix10: add support for Agilex5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <07575ce3-eab7-46dd-baad-8a909124a962@altera.com>
Date: Wed, 19 Nov 2025 01:45:03 +0000
From: "Romli, Khairul Anuar" <khairul.anuar.romli@...era.com>
To: Conor Dooley <conor@...nel.org>
CC: Moritz Fischer <mdf@...nel.org>, Xu Yilun <yilun.xu@...el.com>, Tom Rix
	<trix@...hat.com>, Dinh Nguyen <dinguyen@...nel.org>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, "Rao, Mahesh" <mahesh.rao@...era.com>, "Ng, Adrian Ho
 Yin" <adrian.ho.yin.ng@...era.com>, "Rabara, Niravkumar Laxmidas"
	<nirav.rabara@...era.com>, "linux-fpga@...r.kernel.org"
	<linux-fpga@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: fpga: stratix10: add support for
 Agilex5

On 19/11/2025 9:20 am, Conor Dooley wrote:
> On Wed, Nov 19, 2025 at 07:34:18AM +0800, Khairul Anuar Romli wrote:
>> Agilex5 introduces changes in how reserved memory is mapped and accessed
>> compared to previous SoC generations. Agilex5 compatible allows stratix10-
>> FPGA manager driver to handle these changes.
>>
>> Fallback is added for driver probe and init that rely on matching of table
>> and DT node.
>>
>> Reviewed-by: Xu Yilun <yilun.xu@...el.com>
>> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
>> ---
>> Changes in v5:
>> 	- Revert to oneOf and use enum without items.
>> Changes in v4:
>> 	- Remove redundant "items - enum" as suggested in v3.
>> 	- Simplify compatible property to use contains instead of oneOf.
>> 	- Validate fallback and non-fallback DT. Also validate binding with
>>            dt_binding_check.
>> Changes in v3:
>> 	- Add description for Agilex5 Device
>> 	- Add and define fallback to "intel,agilex-soc-fpga-mgr"
>> 	- Validate against Agilex and Stratix10 (non-fallback) and Agilex5
>> 	  (fallback)
>> Changes in v2:
>> 	- No changes in this patch
>> ---
>>   .../bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml    | 10 +++++++---
>>   1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
>> index 6e536d6b28a9..14437dfc47a4 100644
>> --- a/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
>> +++ b/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
>> @@ -20,9 +20,13 @@ description:
>>   
>>   properties:
>>     compatible:
>> -    enum:
>> -      - intel,stratix10-soc-fpga-mgr
>> -      - intel,agilex-soc-fpga-mgr
>> +    oneOf:
>> +      - enum:
>> +          - intel,stratix10-soc-fpga-mgr
>> +          - intel,agilex-soc-fpga-mgr
> 
> Great, you've fixed this part.
> 
>> +      - enum:
>> +          - intel,agilex5-soc-fpga-mgr
>> +        const: intel,agilex-soc-fpga-mgr
> 
> But unfortunately this is wrong, and you should have noticed it
> because the dts patch you have will produce a warning.
> This one actually does need the items, you had it right in v3.
> You'll note that my v3 feedback specifically said "this construct" and
> was inserted at the point of the redundant single item items list:
> https://lore.kernel.org/all/20251114-countless-vantage-6e18528d2e31@spud/
> 
> pw-bot: changes-requested
> 
> Please take some time to both test and understand the change you are
> making.
> 
> Thanks,
> Conor.
> 

Yeap, this is the part that I am seeing warning during the test and I am 
trying to resolved it now.

I will go through other bindings with rg --multiline that you shared and 
will send next version after all the test is done.

Thank You.

Best Regards,
Khairul

>>   
>>   required:
>>     - compatible
>> -- 
>> 2.43.7
>>