linux-kernel - Re: [PATCH] staging: rtl8723bs: core: fix block comment style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aR2r0A_fBj_w9JgZ@stanley.mountain>
Date: Wed, 19 Nov 2025 14:36:48 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Artur Stupa <arthur.stupa@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: core: fix block comment style issues

On Tue, Nov 18, 2025 at 10:26:40PM -0800, Artur Stupa wrote:
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index 027b2dd0a4b9..a5234fdbf984 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -133,8 +133,8 @@ u8 *rtw_set_ie(u8 *pbuf,
>  }
>  
>  /*----------------------------------------------------------------------------
> -index: the information element id index, limit is the limit for search
> ------------------------------------------------------------------------------*/
> + * index: the information element id index, limit is the limit for search
> + *--------------------------------------------------------------------------*/

We generally don't like these "****************" or "-----------------" lines.

[ snip ]

> @@ -1691,12 +1691,11 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlmeext, u8 *pframe, uint len)
>  		/* pmlmeext->bcn_delay_ratio[delay_ms] = (pmlmeext->bcn_delay_cnt[delay_ms] * 100) /pmlmeext->bcn_cnt; */
>  
>  /*
> -
> -	for (i = 0; i<9; i++)
> -	{
> -			pmlmeext->bcn_delay_cnt[i] , i, pmlmeext->bcn_delay_ratio[i]);
> -	}
> -*/
> + * for (i = 0; i<9; i++)
> + * {
> + *	pmlmeext->bcn_delay_cnt[i] , i, pmlmeext->bcn_delay_ratio[i]);
> + * }
> + */

Delete dead code.  Don't reformat it.

regards,
dan carpenter