linux-kernel - Re: [PATCH] drm/bridge: cdns-dsi: Set bridge connector type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20d0fd9a-9b75-4a4a-9874-0f503ddcc885@ideasonboard.com>
Date: Wed, 19 Nov 2025 13:47:45 +0200
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Swamil Jain <s-jain1@...com>
Cc: devarsht@...com, praneeth@...com, h-shenoy@...com,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 andrzej.hajda@...el.com, neil.armstrong@...aro.org, rfoss@...nel.org,
 Laurent.pinchart@...asonboard.com, jonas@...boo.se,
 jernej.skrabec@...il.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch
Subject: Re: [PATCH] drm/bridge: cdns-dsi: Set bridge connector type

Hi,

On 19/11/2025 13:29, Swamil Jain wrote:
> Set the bridge connector type to DRM_MODE_CONNECTOR_DSI to properly
> identify the DSI connector in the display pipeline.
> 
> Without this, the bridge connector type defaults to
> DRM_MODE_CONNECTOR_Unknown. Hence, to get correct bridge type set the
> bridge connector type to DRM_MODE_CONNECTOR_DSI.
> 
> Signed-off-by: Swamil Jain <s-jain1@...com>
> ---
>  drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> index 09b289f0fcbf..84b5a0cdf722 100644
> --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> @@ -1323,6 +1323,7 @@ static int cdns_dsi_drm_probe(struct platform_device *pdev)
>  	 */
>  	input->id = CDNS_DPI_INPUT;
>  	input->bridge.of_node = pdev->dev.of_node;
> +	input->bridge.type = DRM_MODE_CONNECTOR_DSI;
>  
>  	/* Mask all interrupts before registering the IRQ handler. */
>  	writel(0, dsi->regs + MCTL_MAIN_STS_CTL);

Hmm, how does this all work...

tidss_kms.c calls devm_drm_panel_bridge_add(), which then does
devm_drm_panel_bridge_add_typed() with panel's connector type. Doesn't
that already work?

Why do you need the bridge type to be set, i.e. what's the use case?

Somewhat besides the point of this patch, but input->bridge feels odd.
Why "input"... Why isn't the bridge just in the struct cdns_dsi? And
what's the bridge in cdns_dsi_output? Is that the next bridge?

 Tomi