linux-kernel - Re: [PATCH v7 4/6] btrfs: don't rewrite ret from inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251119120829.GE13846@twin.jikos.cz>
Date: Wed, 19 Nov 2025 13:08:29 +0100
From: David Sterba <dsterba@...e.cz>
To: Johannes Thumshirn <Johannes.Thumshirn@....com>
Cc: Daniel Vacek <neelx@...e.com>, Chris Mason <clm@...com>,
	Josef Bacik <josef@...icpanda.com>, David Sterba <dsterba@...e.com>,
	"linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 4/6] btrfs: don't rewrite ret from inode_permission

On Wed, Nov 19, 2025 at 10:13:10AM +0000, Johannes Thumshirn wrote:
> On 11/19/25 11:08 AM, Johannes Thumshirn wrote:
> > This patch on it's own looks reasonable and IMHO should be merged ASAP
> > to not overwrite the inode_permisison() return value.
> >
> > I think also a
> >
> > Fixes: 23d0b79dfaed ("btrfs: Add unprivileged version of ino_lookup ioctl")
> >
> > would be appropriate
> >
> > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>

Yes this seems to have effects on user space, though hopefully nothing
really bad as the error codes from the permission checks is EACCESS or
EPERM, other than the ENOMEM and similar.

> Forgot to add, this needs your Signed-off-by as well as you've rebased 
> it. Same for the other patches.

I'll add it, the final list will be the original author, Daniel as he
touched it last and mine. The code hasn't evolved over the revisions so
adding everybody who submitted it at some point does not seem adequate.
Still I will also add a text to the changelog linking to the latest v5
series and mentioning people who handled the series in the past to give
credit.