linux-kernel - Re: [PATCH v10 2/2] leds: as3668: Driver for the ams Osram 4-channel i2c LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251120133149.GA661940@google.com>
Date: Thu, 20 Nov 2025 13:31:49 +0000
From: Lee Jones <lee@...nel.org>
To: Lukas Timmermann <linux@...mermann.space>
Cc: pavel@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, linux-leds@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 2/2] leds: as3668: Driver for the ams Osram 4-channel
 i2c LED driver

On Thu, 20 Nov 2025, Lukas Timmermann wrote:

> On Mon, Nov 17, 2025 at 03:00:08AM +0100, Lukas Timmermann wrote:
> > Since there were no existing drivers for the AS3668 or related devices,
> > a new driver was introduced in a separate file. Similar devices were
> > reviewed, but none shared enough characteristics to justify code reuse.
> > As a result, this driver is written specifically for the AS3668.
> > 
> > Signed-off-by: Lukas Timmermann <linux@...mermann.space>
> > ---
> >  MAINTAINERS                |   1 +
> >  drivers/leds/Kconfig       |  13 +++
> >  drivers/leds/Makefile      |   1 +
> >  drivers/leds/leds-as3668.c | 222 +++++++++++++++++++++++++++++++++++++
> >  4 files changed, 237 insertions(+)
> >  create mode 100644 drivers/leds/leds-as3668.c
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 091206c54c63..945d78fef380 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -3511,6 +3511,7 @@ M:	Lukas Timmermann <linux@...mermann.space>
> >  L:	linux-leds@...r.kernel.org
> >  S:	Maintained
> >  F:	Documentation/devicetree/bindings/leds/ams,as3668.yaml
> > +F:	drivers/leds/leds-as3668.c
> >  
> >  ASAHI KASEI AK7375 LENS VOICE COIL DRIVER
> >  M:	Tianshu Qiu <tian.shu.qiu@...el.com>
> > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> > index a104cbb0a001..ec37d55ac14e 100644
> > --- a/drivers/leds/Kconfig
> > +++ b/drivers/leds/Kconfig
> > @@ -100,6 +100,19 @@ config LEDS_ARIEL
> >  
> >  	  Say Y to if your machine is a Dell Wyse 3020 thin client.
> >  
> > +config LEDS_OSRAM_AMS_AS3668
> I've modified this line as requested in patch series v9. After comparing
> this with other configuration options in drivers/leds/Kconfig, this
> seems out of place. Shouldn't we keep this consistent?

There are a few other examples in there, so consistency is less of an
issue.  I personally think it provides a better picture of the device if
the manufacture is mentioned as well.

But this is not a blocking point.  Take your preference.

-- 
Lee Jones [李琼斯]