linux-kernel - Re: [PATCH v2 5/5] arm64: dts: mediatek: mt6359: Add alarm-sta-supported property to RTC node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14caa2fe-e1fa-471a-8c6c-aafd4aaff4be@kernel.org>
Date: Thu, 20 Nov 2025 14:39:49 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: ot_shunxi.zhang@...iatek.com, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Eddie Huang <eddie.huang@...iatek.com>, Sean Wang <sean.wang@...iatek.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>, Lee Jones
 <lee@...nel.org>, Vince-WL.Liu@...iatek.com, sirius.wang@...iatek.com,
 Jh.Hsu@...iatek.com
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 5/5] arm64: dts: mediatek: mt6359: Add
 alarm-sta-supported property to RTC node

On 20/11/2025 13:18, ot_shunxi.zhang@...iatek.com wrote:
> From: Shunxi Zhang <ot_shunxi.zhang@...iatek.com>
> 
> This patch adds the 'mediatek,alarm-sta-supported' property to the RTC


Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94

> node in the MediaTek MT6359 device tree source file. This property
> indicates that the RTC supports alarm status functionality, which is
> essential for proper power management and wake-up events.
> 
> Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@...iatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt6359.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> index 467d8a4c2aa7..62a2d745c8d2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> @@ -302,6 +302,7 @@ mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub {
>  
>  		mt6359rtc: rtc {
>  			compatible = "mediatek,mt6358-rtc";
> +			mediatek,alarm-sta-supported;

NAK, there is no such ABI.

Test your code BEFORE you send it.

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.


Best regards,
Krzysztof