linux-kernel - Re: [PATCH v5 03/13] coresight: Refactor etm4_config_timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251120142520.GB724103@e132581.arm.com>
Date: Thu, 20 Nov 2025 14:25:20 +0000
From: Leo Yan <leo.yan@....com>
To: James Clark <james.clark@...aro.org>,
	Mike Leach <mike.leach@...aro.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jonathan Corbet <corbet@....net>,
	Randy Dunlap <rdunlap@...radead.org>, coresight@...ts.linaro.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org
Subject: Re: [PATCH v5 03/13] coresight: Refactor
 etm4_config_timestamp_event()

On Thu, Nov 20, 2025 at 02:18:21PM +0000, Coresight ML wrote:

[...]

> Maybe define a general macro but with extra checking:
> 
>   #define TRCCNTCTLRn_RLDEVENT_MASK  GENMASK(15, 8)
> 
>   #define ETM4_RS_SEL_EVENT(paired, sel) ({  \
>       if (paired)                            \
>           assert(!(sel & ~GENMASK(3, 0)));   \
>       else                                   \
>           assert(!(sel & ~GENMASK(4, 0)));   \
>       FIELD_PREP(TRCCNTCTLRn_RLDEVENT_MASK,  \
>                  ((paird << 7) | sel));      \
>   })

It'd be better to use BUILD_BUG_ON() instead of assert().