linux-kernel - Re: (subset) [PATCH 00/44] Change a lot of min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <176365036384.566630.2992984118137417732.b4-ty@kernel.dk>
Date: Thu, 20 Nov 2025 07:52:43 -0700
From: Jens Axboe <axboe@...nel.dk>
To: linux-kernel@...r.kernel.org, david.laight.linux@...il.com
Cc: Alan Stern <stern@...land.harvard.edu>, 
 Alexander Viro <viro@...iv.linux.org.uk>, 
 Alexei Starovoitov <ast@...nel.org>, Andi Shyti <andi.shyti@...nel.org>, 
 Andreas Dilger <adilger.kernel@...ger.ca>, Andrew Lunn <andrew@...n.ch>, 
 Andrew Morton <akpm@...ux-foundation.org>, 
 Andrii Nakryiko <andrii@...nel.org>, 
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
 Ard Biesheuvel <ardb@...nel.org>, 
 Arnaldo Carvalho de Melo <acme@...nel.org>, 
 Bjorn Helgaas <bhelgaas@...gle.com>, Borislav Petkov <bp@...en8.de>, 
 Christian Brauner <brauner@...nel.org>, 
 Christian König <christian.koenig@....com>, 
 Christoph Hellwig <hch@....de>, Daniel Borkmann <daniel@...earbox.net>, 
 Dan Williams <dan.j.williams@...el.com>, 
 Dave Hansen <dave.hansen@...ux.intel.com>, 
 Dave Jiang <dave.jiang@...el.com>, David Ahern <dsahern@...nel.org>, 
 Davidlohr Bueso <dave@...olabs.net>, 
 "David S. Miller" <davem@...emloft.net>, Dennis Zhou <dennis@...nel.org>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Herbert Xu <herbert@...dor.apana.org.au>, Ingo Molnar <mingo@...hat.com>, 
 Jakub Kicinski <kuba@...nel.org>, Jakub Sitnicki <jakub@...udflare.com>, 
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>, 
 Jarkko Sakkinen <jarkko@...nel.org>, "Jason A. Donenfeld" <Jason@...c4.com>, 
 Jiri Slaby <jirislaby@...nel.org>, Johannes Weiner <hannes@...xchg.org>, 
 John Allen <john.allen@....com>, 
 Jonathan Cameron <jonathan.cameron@...wei.com>, 
 Juergen Gross <jgross@...e.com>, Kees Cook <kees@...nel.org>, 
 KP Singh <kpsingh@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, 
 "Martin K. Petersen" <martin.petersen@...cle.com>, 
 "Matthew Wilcox (Oracle)" <willy@...radead.org>, 
 Mika Westerberg <westeri@...nel.org>, Mike Rapoport <rppt@...nel.org>, 
 Miklos Szeredi <miklos@...redi.hu>, Namhyung Kim <namhyung@...nel.org>, 
 Neal Cardwell <ncardwell@...gle.com>, nic_swsd@...ltek.com, 
 OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>, 
 Olivia Mackall <olivia@...enic.com>, Paolo Abeni <pabeni@...hat.com>, 
 Paolo Bonzini <pbonzini@...hat.com>, Peter Huewe <peterhuewe@....de>, 
 Peter Zijlstra <peterz@...radead.org>, 
 "Rafael J. Wysocki" <rafael@...nel.org>, 
 Sean Christopherson <seanjc@...gle.com>, 
 Srinivas Kandagatla <srini@...nel.org>, 
 Stefano Stabellini <sstabellini@...nel.org>, 
 Steven Rostedt <rostedt@...dmis.org>, Tejun Heo <tj@...nel.org>, 
 Theodore Ts'o <tytso@....edu>, Thomas Gleixner <tglx@...utronix.de>, 
 Tom Lendacky <thomas.lendacky@....com>, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>, x86@...nel.org, 
 Yury Norov <yury.norov@...il.com>, amd-gfx@...ts.freedesktop.org, 
 bpf@...r.kernel.org, cgroups@...r.kernel.org, 
 dri-devel@...ts.freedesktop.org, io-uring@...r.kernel.org, 
 kvm@...r.kernel.org, linux-acpi@...r.kernel.org, 
 linux-block@...r.kernel.org, linux-crypto@...r.kernel.org, 
 linux-cxl@...r.kernel.org, linux-efi@...r.kernel.org, 
 linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
 linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org, 
 linux-integrity@...r.kernel.org, linux-mm@...ck.org, 
 linux-nvme@...ts.infradead.org, linux-pci@...r.kernel.org, 
 linux-perf-users@...r.kernel.org, linux-scsi@...r.kernel.org, 
 linux-serial@...r.kernel.org, linux-trace-kernel@...r.kernel.org, 
 linux-usb@...r.kernel.org, mptcp@...ts.linux.dev, netdev@...r.kernel.org, 
 usb-storage@...ts.one-eyed-alien.net, David Hildenbrand <david@...nel.org>
Subject: Re: (subset) [PATCH 00/44] Change a lot of min_t() that might mask
 high bits

On Wed, 19 Nov 2025 22:40:56 +0000, david.laight.linux@...il.com wrote:
> It in not uncommon for code to use min_t(uint, a, b) when one of a or b
> is 64bit and can have a value that is larger than 2^32;
> This is particularly prevelant with:
> 	uint_var = min_t(uint, uint_var, uint64_expression);
> 
> Casts to u8 and u16 are very likely to discard significant bits.
> 
> [...]

Applied, thanks!

[12/44] block: use min() instead of min_t()
        commit: 9420e720ad192c53c8d2803c5a2313b2d586adbd

Best regards,
-- 
Jens Axboe