linux-kernel - Re: [PATCH net-next 08/15] net: dsa: sja1105: transition OF-based MDIO drivers to standalone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251120151458.e5syoeay45fuajlt@skbuf>
Date: Thu, 20 Nov 2025 17:14:58 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: Lee Jones <lee@...nel.org>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 08/15] net: dsa: sja1105: transition OF-based
 MDIO drivers to standalone

Hi Lee,

Thank you for commenting on the patch!

On Thu, Nov 20, 2025 at 02:40:46PM +0000, Lee Jones wrote:
> The MFD API is not to be {ab}used out side of drivers/mfd.

If mfd_add_devices() is not to be used outside of drivers/mfd, why
export it to the global include/linux/mfd/core.h in the first place,
rather than make the header available just to drivers/mfd?

> Maybe of_platform_populate() will scratch your itch instead.

I did already explore of_platform_populate() on this thread which asked
for advice (to which you were also copied):
https://lore.kernel.org/lkml/20221222134844.lbzyx5hz7z5n763n@skbuf/

    It looks like of_platform_populate() would be an alternative option for
    this task, but that doesn't live up to the task either. It will assume
    that the addresses of the SoC children are in the CPU's address space
    (IORESOURCE_MEM), and attempt to translate them. It simply doesn't have
    the concept of IORESOURCE_REG. The MFD drivers which call
    of_platform_populate() (simple-mfd-i2c.c) simply don't have unit
    addresses for their children, and this is why address translation isn't
    a problem for them.

I'm not trying to start an argument, but as you can see, I've been stuck
on this problem for years, and I'm between a rock and a hard place.