linux-kernel - [PATCH] platform/x86: asus-armoury: fix mini-led mode show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251120024059.1341326-1-denis.benato@linux.dev>
Date: Thu, 20 Nov 2025 03:40:59 +0100
From: Denis Benato <denis.benato@...ux.dev>
To: linux-kernel@...r.kernel.org
Cc: platform-driver-x86@...r.kernel.org,
	"Hans de Goede" <hansg@...nel.org>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	"Limonciello, Mario" <mario.limonciello@....com>,
	"Luke D . Jones" <luke@...nes.dev>,
	"Alok Tiwari" <alok.a.tiwari@...cle.com>,
	"Derek John Clark" <derekjohn.clark@...il.com>,
	"Mateusz Schyboll" <dragonn@...pl>,
	porfet828@...il.com,
	"Denis Benato" <benato.denis96@...il.com>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Denis Benato <denis.benato@...ux.dev>
Subject: [PATCH] platform/x86: asus-armoury: fix mini-led mode show

Perform the actual check of the mini-led mode against supported modes and do not return the first one regardless of the WMI devstate.

Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
Closes: https://lore.kernel.org/all/aR1xbxEQyQPEvB9o@stanley.mountain/
Signed-off-by: Denis Benato <denis.benato@...ux.dev>
---
 drivers/platform/x86/asus-armoury.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
index d6aba68515e2..c4919f3bf4b2 100644
--- a/drivers/platform/x86/asus-armoury.c
+++ b/drivers/platform/x86/asus-armoury.c
@@ -373,7 +373,8 @@ static ssize_t mini_led_mode_current_value_show(struct kobject *kobj,
 	mode = FIELD_GET(ASUS_MINI_LED_MODE_MASK, 0);
 
 	for (i = 0; i < mini_led_mode_map_size; i++)
-		return sysfs_emit(buf, "%u\n", mini_led_mode_map[i]);
+		if (mode == mini_led_mode_map[i])
+			return sysfs_emit(buf, "%u\n", i);
 
 	pr_warn("Unrecognized mini-LED mode: %u", mode);
 	return -EINVAL;
-- 
2.52.0