linux-kernel - Re: [PATCH] dt-bindings: arm: qcom: add ipq8064 board variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <691f3465.050a0220.105096.7667@mx.google.com>
Date: Thu, 20 Nov 2025 16:31:47 +0100
From: Christian Marangi <ansuelsmth@...il.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: arm: qcom: add ipq8064 board variants

On Thu, Nov 20, 2025 at 04:25:37PM +0100, Konrad Dybcio wrote:
> On 11/20/25 2:54 PM, Christian Marangi wrote:
> > Document QCOM ipq8064 board variants ipq8062, ipq8065, ipq8066,
> > ipq8068, ipq8069 now matched by the QCOM cpufreq nvmem driver if
> > socinfo can't derive the variant from SMEM.
> > 
> > Suggested-by: Rob Herring <robh@...nel.org>
> > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > ---
> >  .../devicetree/bindings/arm/qcom.yaml         | 20 +++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > index 18b5ed044f9f..0eb1619fede8 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > @@ -299,12 +299,32 @@ properties:
> >                - qcom,ipq5424-rdp466
> >            - const: qcom,ipq5424
> >  
> > +      - items:
> > +          - const: qcom,ipq8062
> > +          - const: qcom,ipq8064
> 
> Since 'items' requires that all items are present (and in this order),
> we would normally have a board name go first.. but I suppose this is
> some sort of a fix to the issue that sparked this (posting the link
> for others to have more context)
> 
> But since these SoCs do exist, I wouldn't say this is necessarily
> wrong..
>

Well we can see this as a ""template"" for device that might be added
using the ipq8062 or ipq8065 compatible.

When device with that variant will be added we would have to just add an
enum with the real device name on top of it (as first element).

Honestly I should have added these compatible long time ago as on
OpenWrt we have tons of device that are ipq8062 or ipq8065 with the
compatible structure

"device,name", "qcom,ipq8065", "qcom,ipq8064".

I feel it might be wrong to simply add to the list "qcom,ipq8065"
without the "qcom,ipq8064" part.

> https://lore.kernel.org/linux-arm-msm/20251105112136.371376-2-ansuelsmth@gmail.com/
>

Maybe I should add a Ref: tag referencing that?

-- 
	Ansuel