linux-kernel - Re: [PATCH net-next v5 4/5] netconsole: resume previously deactivated target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jlxgiuqnkwdjujcpv2eaaq4b7yvkynkabnhwlt34cwctladpim@aoeikoylbnld>
Date: Thu, 20 Nov 2025 07:47:11 -0800
From: Breno Leitao <leitao@...ian.org>
To: Andre Carvalho <asantostc@...il.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>, 
	Simon Horman <horms@...nel.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v5 4/5] netconsole: resume previously
 deactivated target

On Wed, Nov 19, 2025 at 07:49:22AM +0000, Andre Carvalho wrote:
> Attempt to resume a previously deactivated target when the associated
> interface comes back (NETDEV_UP event is received) by calling
> __netpoll_setup on the device.
> 
> Depending on how the target was setup (by mac or interface name), the
> corresponding field is compared with the device being brought up.
> 
> Targets that are candidates for resuming are removed from the target list
> and added to a temp list, as __netpoll_setup is IRQ unsafe.
> __netpoll_setup assumes RTNL is held (which is guaranteed to be the
> case when handling the event). In case of success, hold a reference to
> the device which will be removed upon target (or netconsole) removal by
> netpoll_cleanup.
> 
> Target transitions to STATE_DISABLED in case of failures resuming it to
> avoid retrying the same target indefinitely.
> 
> Signed-off-by: Andre Carvalho <asantostc@...il.com>

Reviewed-by: Breno Leitao <leitao@...ian.org>

This is now conflicting with Gustavo's patchset. I would suggest we get
Gustavo's patches merged first, and then you respin this one, please.

Thus, I am marking this as "change-requested" just to help the main
network maintainers, if that is the right process.

--
pw-bot: cr