linux-kernel - Re: [RFC net-next v1 0/7] highly rfc macb usrio/tsu patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251120-unreal-antitrust-e32900cf893b@spud>
Date: Thu, 20 Nov 2025 16:31:11 +0000
From: Conor Dooley <conor@...nel.org>
To: netdev@...r.kernel.org
Cc: Conor Dooley <conor.dooley@...rochip.com>,
	Valentina.FernandezAlanis@...rochip.com,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Daire McNamara <daire.mcnamara@...rochip.com>,
	Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	Richard Cochran <richardcochran@...il.com>,
	Samuel Holland <samuel.holland@...ive.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org,
	Dave Stevenson <dave.stevenson@...pberrypi.com>,
	Sean Anderson <sean.anderson@...ux.dev>,
	Vineeth Karumanchi <vineeth.karumanchi@....com>,
	Abin Joseph <abin.joseph@....com>, neil.armstrong@...aro.org
Subject: Re: [RFC net-next v1 0/7] highly rfc macb usrio/tsu patches

On Thu, Nov 20, 2025 at 04:26:02PM +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> Hey folks,
> 
> After doing some debugging of broken tsu/ptp support on mpfs, I've come
> up with some very rfc patches that I'd like opinions on - particularly
> because they impact a bunch of platforms that I have no access to at all
> and have no idea how they work. The at91 platforms I can just ask
> Nicolas about (and he already provided some info directly, so I'm not
> super worried at least about the usrio portion there) but the others
> my gut says are likely incorrect in the driver at the moment.
> 
> These patches *are* fairly opinionated and not necessarily technically
> correct or w/e. The only thing I am confident in saying that they are is
> more deliberate than what's being done at the moment.
> 
> At the very least, it'd be good of the soc vendor folks could check
> their platforms and see if their usrio stuff actually lines up with what
> the driver currently calls "macb_default_usrio". Ours didn't and it was
> a nasty surprise.
> 
> Cheers,
> Conor.
> 
> CC: Valentina.FernandezAlanis@...rochip.com
> CC: Andrew Lunn <andrew+netdev@...n.ch>
> CC: David S. Miller <davem@...emloft.net>
> CC: Eric Dumazet <edumazet@...gle.com>
> CC: Jakub Kicinski <kuba@...nel.org>
> CC: Paolo Abeni <pabeni@...hat.com>
> CC: Rob Herring <robh@...nel.org>
> CC: Krzysztof Kozlowski <krzk+dt@...nel.org>
> CC: Conor Dooley <conor+dt@...nel.org>
> CC: Daire McNamara <daire.mcnamara@...rochip.com>
> CC: Paul Walmsley <pjw@...nel.org>
> CC: Palmer Dabbelt <palmer@...belt.com>
> CC: Albert Ou <aou@...s.berkeley.edu>
> CC: Alexandre Ghiti <alex@...ti.fr>
> CC: Nicolas Ferre <nicolas.ferre@...rochip.com>
> CC: Claudiu Beznea <claudiu.beznea@...on.dev>
> CC: Richard Cochran <richardcochran@...il.com>
> CC: Samuel Holland <samuel.holland@...ive.com>
> CC: netdev@...r.kernel.org
> CC: devicetree@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> CC: linux-riscv@...ts.infradead.org
> CC: Neil Armstrong <narmstrong@...libre.com>

The perils of grabbing addresses from git blame..
+CC Neil @ linaro.

> CC: Dave Stevenson <dave.stevenson@...pberrypi.com>
> CC: Sean Anderson <sean.anderson@...ux.dev>
> CC: Vineeth Karumanchi <vineeth.karumanchi@....com>
> CC: Abin Joseph <abin.joseph@....com>
> 
> Conor Dooley (7):
>   riscv: dts: microchip: add tsu clock to macb on mpfs
>   net: macb: warn on pclk use as a tsu_clk fallback
>   net: macb: rename macb_default_usrio to at91_default_usrio as not all
>     platforms have mii mode control in usrio
>   net: macb: np4 doesn't need a usrio pointer
>   dt-bindings: net: macb: add property indicating timer adjust mode
>   net: macb: afaict, the driver doesn't support tsu timer adjust mode
>   net: macb: add mpfs specific usrio configuration
> 
>  .../devicetree/bindings/net/cdns,macb.yaml    |  15 +++
>  arch/riscv/boot/dts/microchip/Makefile.orig   |  26 ++++
>  arch/riscv/boot/dts/microchip/mpfs.dtsi       |   8 +-
>  drivers/net/ethernet/cadence/macb.h           |   3 +
>  drivers/net/ethernet/cadence/macb_main.c      | 123 +++++++++++-------
>  5 files changed, 125 insertions(+), 50 deletions(-)
>  create mode 100644 arch/riscv/boot/dts/microchip/Makefile.orig
> 
> -- 
> 2.51.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)