linux-kernel - Re: [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ce7b889-f03d-4a41-8866-e137ad45e77b@kernel.org>
Date: Thu, 20 Nov 2025 17:59:17 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Riccardo Mereu <r.mereu.kernel@...uino.cc>, andersson@...nel.org,
 konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, broonie@...nel.org
Cc: linux@...ck-us.net, Jonathan.Cameron@...wei.com, wenswang@...h.net,
 naresh.solanki@...ements.com, michal.simek@....com, nuno.sa@...log.com,
 chou.cosmo@...il.com, grantpeltier93@...il.com, eajames@...ux.ibm.com,
 farouk.bouabid@...rry.de, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-spi@...r.kernel.org, m.facchin@...uino.cc,
 Riccardo Mereu <r.mereu@...uino.cc>
Subject: Re: [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino
 unoq

On 20/11/2025 16:58, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@...uino.cc>
> 
> Arduino UnoQ is a single-board computer combining Qualcomm
> Dragonwing™ QRB2210 microprocessor with STMicroelectronics STM32U585
> microcontroller.
> Support to a simply boot to shell environment includes:
> - UART, I2C, SPI
> - onboard LEDS
> - eMMC
> - WLAN and BT
> 
> Signed-off-by: Riccardo Mereu <r.mereu@...uino.cc>
> ---
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  .../boot/dts/qcom/qrb2210-arduino-imola.dts   | 459 ++++++++++++++++++
>  2 files changed, 460 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> 



> +
> +&spi5 {
> +	status = "okay";
> +
> +	spidev@0 {
> +		reg = <0>;
> +		compatible = "arduino,unoq-mcu";

If there is going to be new version (no need to resend just for that):
Please re-order these two, compatible is always the fist property, reg
follows, see also DTS coding style.

Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>


Best regards,
Krzysztof