linux-kernel - Re:Re: [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d61df3a.2f2f.19a9f382a58.Coremail.slark_xiao@163.com>
Date: Thu, 20 Nov 2025 11:04:09 +0800 (CST)
From: "Slark Xiao" <slark_xiao@....com>
To: "Dmitry Baryshkov" <dmitry.baryshkov@....qualcomm.com>
Cc: "Loic Poulain" <loic.poulain@....qualcomm.com>, mani@...nel.org,
	ryazanov.s.a@...il.com, johannes@...solutions.net,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, mhi@...ts.linux.dev,
	linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re:Re: [PATCH v3 2/2] net: wwan: mhi: Add network support for
 Foxconn T99W760

At 2025-11-19 21:47:33, "Dmitry Baryshkov" <dmitry.baryshkov@....qualcomm.com> wrote:
>On Wed, Nov 19, 2025 at 02:08:33PM +0100, Loic Poulain wrote:
>> On Wed, Nov 19, 2025 at 12:27 PM Dmitry Baryshkov
>> <dmitry.baryshkov@....qualcomm.com> wrote:
>> >
>> > On Wed, Nov 19, 2025 at 06:56:15PM +0800, Slark Xiao wrote:
>> > > T99W760 is designed based on Qualcomm SDX35 chip. It use similar
>> > > architechture with SDX72/SDX75 chip. So we need to assign initial
>> > > link id for this device to make sure network available.
>> > >
>> > > Signed-off-by: Slark Xiao <slark_xiao@....com>
>> > > ---
>> > >  drivers/net/wwan/mhi_wwan_mbim.c | 3 ++-
>> > >  1 file changed, 2 insertions(+), 1 deletion(-)
>> > >
>> > > diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
>> > > index c814fbd756a1..a142af59a91f 100644
>> > > --- a/drivers/net/wwan/mhi_wwan_mbim.c
>> > > +++ b/drivers/net/wwan/mhi_wwan_mbim.c
>> > > @@ -98,7 +98,8 @@ static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim
>> > >  static int mhi_mbim_get_link_mux_id(struct mhi_controller *cntrl)
>> > >  {
>> > >       if (strcmp(cntrl->name, "foxconn-dw5934e") == 0 ||
>> > > -         strcmp(cntrl->name, "foxconn-t99w515") == 0)
>> > > +         strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
>> > > +         strcmp(cntrl->name, "foxconn-t99w760") == 0)
>> >
>> > Can we replace this list of strinc comparisons with some kind of device
>> > data, being set in the mhi-pci-generic driver?
>> 
>> If we move this MBIM-specific information into mhi-pci-generic, we
>> should consider using a software node (e.g. via
>> device_add_software_node) so that these properties can be accessed
>> through the generic device-property API.
>
Hi Loic,
The original solution is we defined this mux_id in mhi-pci-generic side and 
transfer it to MBIM side. But it is rejected in last year.
Why we move it back again?

>Works for me too.
>
>-- 
>With best wishes
>Dmitry