linux-kernel - Re: [PATCH net-next 04/15] net: mdio: add generic driver for NXP SJA1110 100BASE-TX embedded PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251120184931.fanw7fmcyh7d6ef7@skbuf>
Date: Thu, 20 Nov 2025 20:49:31 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 04/15] net: mdio: add generic driver for NXP
 SJA1110 100BASE-TX embedded PHYs

On Thu, Nov 20, 2025 at 06:55:56PM +0100, Maxime Chevallier wrote:
> > +	config.regmap = regmap;
> > +	config.parent = dev;
> > +	config.name = dev_name(dev);
> > +	config.resource = platform_get_resource(pdev, IORESOURCE_REG, 0);
> 
> Just to clarify, a small comment to say that it's OK of
> platform_get_resource() returns NULL maybe ?

Good forethought. I can already imagine tens of patches to 'fix' this if
merged like that..

Thanks for the review!