linux-kernel - Re: [PATCH] rust: Convert PhysAddr type alias into newtype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72=j7EOCLjboXKck841F1wfgY1eDQ5DsTZMV5PsGzgRADg@mail.gmail.com>
Date: Thu, 20 Nov 2025 20:55:44 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Gent Binaku <binakugent@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, "open list:RUST" <rust-for-linux@...r.kernel.org>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rust: Convert PhysAddr type alias into newtype

On Thu, Nov 20, 2025 at 8:37 PM Gent Binaku <binakugent@...il.com> wrote:
>
> diff --git c/rust/kernel/lib.rs i/rust/kernel/lib.rs

It seems the patch is mangled somehow: diffs appear twice, and the
deltas for `rust/kernel/phys_addr.rs` seem to be w.r.t. some
intermediate state (?).

Did you perhaps edit it manually?

I would suggest re-generating it with `git format-patch` and applying
it to a clean tree with `git am` to double-check that it works well
etc.

I hope that helps, and thanks for the patch!

Cheers,
Miguel