[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <yrc7itk6yidsomznmvzcswvs7jhq3747vv677bjogoqji2bwrw@gfz7xelxkvrf>
Date: Thu, 20 Nov 2025 21:27:39 +0100
From: Lukas Timmermann <linux@...mermann.space>
To: Krzysztof Kozlowski <krzk@...nel.org>,
Henrik Grimler <henrik@...mler.se>
Cc: Alim Akhtar <alim.akhtar@...sung.com>, Rob Herring <robh@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Alexandre Marquet <tb@...arquet.fr>,
linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] ARM: dts: exynos: Add Samsung Manta (Google Nexus 10)
On Thu, Nov 20, 2025 at 06:36:29PM +0100, Krzysztof Kozlowski wrote:
> On 20/11/2025 18:31, Henrik Grimler wrote:
> > Hi Lukas,
> >
> > On Thu, Nov 20, 2025 at 03:40:15PM +0100, Lukas Timmermann wrote:
> >> From: Alexandre Marquet <tb@...arquet.fr>
> >>
> >> Manta is the code name for Google Nexus 10, and was manufactured by
> >> Samsung. This patch adds initial device-tree file for this board.
> >>
> >> Co-developed-by: Alexandre Marquet <tb@...arquet.fr>
> >> Signed-off-by: Alexandre Marquet <tb@...arquet.fr>
> >> Co-developed-by: Lukas Timmermann <linux@...mermann.space>
> >> Signed-off-by: Lukas Timmermann <linux@...mermann.space>
> >
> > Awesome! I think this series would benefit from a cover letter
> > explaining what features are working, and perhaps saying something
> > about other patches that will be sent separately (if any). The as3668
> > led driver and bindings for example has not been merged, right? Adding
> > the lore link in a cover letter would therefore help reviewers.
>
> If "not merged" in the meaning of not taken by maintainer for next, then
> this is quite important because it not only blocks this patch but would
> cause failures in CI leading me to being grumpy.
>
> Samsung SoC follows maintainer-soc-clean-dts profile. Please always
> explicitly document such stuff (bindings in fly).
>
> Best regards,
> Krzysztof
>
I just noticed, that my cover letter did not get send to the mailing.
That was unintentional. In there, I wrote that this patch depends on an
earlier patch which still needs some work. Should I also add that to the
individual patch in future mails?
I'm still quite new to the mailing list workflow. I'm sorry for any
misunderstandings.
Best regards,
Lukas Timmermann
Powered by blists - more mailing lists