linux-kernel - Re: [PATCH] PM / devfreq: hisi: Fix potential UAF in OPP handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGTfZH2nK9OU5Q63LCATkNgts4R-NOZyPr_eJQHYpPupDFNYrw@mail.gmail.com>
Date: Thu, 20 Nov 2025 14:43:10 +0900
From: Chanwoo Choi <chanwoo@...nel.org>
To: "zhangpengjie (A)" <zhangpengjie2@...wei.com>
Cc: myungjoo.ham@...sung.com, kyungmin.park@...sung.com, cw00.choi@...sung.com, 
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	zhanjie9@...ilicon.com, zhenglifeng1@...wei.com, lihuisong@...wei.com, 
	yubowen8@...wei.com, linhongye@...artners.com, linuxarm@...wei.com, 
	jonathan.cameron@...wei.com
Subject: Re: [PATCH] PM / devfreq: hisi: Fix potential UAF in OPP handling

Hi,

I'm sorry for late reply.

Acked-by: Chanwoo Choi <cw00.choi@...sung.com>

If you need to apply this patch to other git repository with some
related patch, I agree.

Thanks,

On Thu, Nov 20, 2025 at 10:31 AM zhangpengjie (A)
<zhangpengjie2@...wei.com> wrote:
>
>
> Hi All,
>
> This is a friendly follow-up on this patch.
>
> Given that everyone is often busy with various tasks, I wanted to make
> sure it doesn't fall through the cracks.
>
> Thank you for your time and review.
>
> Best regards,
> Pengjie Zhang
>
> On 9/15/2025 2:21 PM, Pengjie Zhang wrote:
> > Ensure all required data is acquired before calling dev_pm_opp_put(opp)
> > to maintain correct resource acquisition and release order.
> >
> > Fixes: 7da2fdaaa1e6 ("PM / devfreq: Add HiSilicon uncore frequency scaling driver")
> > Signed-off-by: Pengjie Zhang <zhangpengjie2@...wei.com>
> > ---
> >   drivers/devfreq/hisi_uncore_freq.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/hisi_uncore_freq.c b/drivers/devfreq/hisi_uncore_freq.c
> > index 96d1815059e3..c1ed70fa0a40 100644
> > --- a/drivers/devfreq/hisi_uncore_freq.c
> > +++ b/drivers/devfreq/hisi_uncore_freq.c
> > @@ -265,10 +265,11 @@ static int hisi_uncore_target(struct device *dev, unsigned long *freq,
> >               dev_err(dev, "Failed to get opp for freq %lu hz\n", *freq);
> >               return PTR_ERR(opp);
> >       }
> > -     dev_pm_opp_put(opp);
> >
> >       data = (u32)(dev_pm_opp_get_freq(opp) / HZ_PER_MHZ);
> >
> > +     dev_pm_opp_put(opp);
> > +
> >       return hisi_uncore_cmd_send(uncore, HUCF_PCC_CMD_SET_FREQ, &data);
> >   }
> >
>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics