linux-kernel - Re: [PATCH net-next v5 3/3] net: ti: icssm-prueth: Adds support for ICSSM RSTP switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1355121310.5320.1763619951092.JavaMail.zimbra@couthit.local>
Date: Thu, 20 Nov 2025 11:55:51 +0530 (IST)
From: Parvathi Pudi <parvathi@...thit.com>
To: Simon Horman <horms@...nel.org>
Cc: Parvathi Pudi <parvathi@...thit.com>, andrew+netdev <andrew+netdev@...n.ch>, 
	davem <davem@...emloft.net>, edumazet <edumazet@...gle.com>, 
	kuba <kuba@...nel.org>, pabeni <pabeni@...hat.com>, 
	danishanwar <danishanwar@...com>, rogerq <rogerq@...nel.org>, 
	pmohan <pmohan@...thit.com>, basharath <basharath@...thit.com>, 
	afd <afd@...com>, linux-kernel <linux-kernel@...r.kernel.org>, 
	netdev <netdev@...r.kernel.org>, 
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, 
	ALOK TIWARI <alok.a.tiwari@...cle.com>, pratheesh <pratheesh@...com>, 
	j-rameshbabu <j-rameshbabu@...com>, 
	Vignesh Raghavendra <vigneshr@...com>, praneeth <praneeth@...com>, 
	srk <srk@...com>, rogerq <rogerq@...com>, 
	krishna <krishna@...thit.com>, mohan <mohan@...thit.com>
Subject: Re: [PATCH net-next v5 3/3] net: ti: icssm-prueth: Adds support for
 ICSSM RSTP switch

Hi,

> On Thu, Nov 13, 2025 at 03:40:23PM +0530, Parvathi Pudi wrote:
> 
> ...
> 
>> @@ -1012,17 +1074,77 @@ static int icssm_emac_ndo_stop(struct net_device *ndev)
>>  	hrtimer_cancel(&emac->tx_hrtimer);
>>  
>>  	/* stop the PRU */
>> -	rproc_shutdown(emac->pru);
>> +	if (!PRUETH_IS_EMAC(prueth))
>> +		icssm_prueth_sw_shutdown_prus(emac, ndev);
>> +	else
>> +		rproc_shutdown(emac->pru);
>> +
>> +	/* free table memory of the switch */
>> +	if (PRUETH_IS_SWITCH(emac->prueth))
>> +		icssm_prueth_sw_free_fdb_table(prueth);
> 
> The conditional block above appears to open-code icssm_prueth_free_memory()
> which is also called below. I don't think this this duplication causes
> any harm, as it looks like the second, indirect, call to
> icssm_prueth_sw_free_fdb_table() will be a noop. But it does seem
> unnecessary.
> 

Sure. We will address this and remove the duplicate code.


Thanks and Regards,
Parvathi.