linux-kernel - Re: [PATCH v4 02/15] gpio: brcmstb: Use modern PM macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdxDz4hG8TH2yGbQ1CmFTSd8m+6sBfuvD-aybuXY9SoQg@mail.gmail.com>
Date: Thu, 20 Nov 2025 09:02:50 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>, Doug Berger <opendmb@...il.com>, 
	Florian Fainelli <florian.fainelli@...adcom.com>, bcm-kernel-feedback-list@...adcom.com, 
	Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Hoan Tran <hoan@...amperecomputing.com>, Andy Shevchenko <andy@...nel.org>, 
	Daniel Palmer <daniel@...ngy.jp>, Romain Perier <romain.perier@...il.com>, 
	Grygorii Strashko <grygorii.strashko@...com>, Santosh Shilimkar <ssantosh@...nel.org>, 
	Kevin Hilman <khilman@...nel.org>, Robert Jarzmik <robert.jarzmik@...e.fr>, 
	Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>, Masami Hiramatsu <mhiramat@...nel.org>, 
	Shubhrajyoti Datta <shubhrajyoti.datta@....com>, Srinivas Neeli <srinivas.neeli@....com>, 
	Michal Simek <michal.simek@....com>, linux-gpio@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	linux-omap@...r.kernel.org
Subject: Re: [PATCH v4 02/15] gpio: brcmstb: Use modern PM macros

On Thu, Nov 20, 2025 at 2:46 AM Jisheng Zhang <jszhang@...nel.org> wrote:
> On Wed, Nov 19, 2025 at 07:45:17PM +0200, Andy Shevchenko wrote:
> > On Thu, Nov 20, 2025 at 12:33:14AM +0800, Jisheng Zhang wrote:

...

> > >  static const struct dev_pm_ops brcmstb_gpio_pm_ops = {
> > > -   .suspend_noirq  = brcmstb_gpio_suspend,
> > > -   .resume_noirq = brcmstb_gpio_resume,
> > > +   .suspend_noirq = pm_sleep_ptr(brcmstb_gpio_suspend),
> > > +   .resume_noirq = pm_sleep_ptr(brcmstb_gpio_resume),
> >
> > Can it be DEFINE_NOIRQ_DEV_PM_OPS() / NOIRQ_SYSTEM_SLEEP_PM_OPS()?
>
> Yep I agree with you. But IMHO, it's better to make the
> DEFINE_NOIRQ_DEV_PM_OPS() switching as a seperate patch and merge this
> series which wants to clean up various #ifdef #endif usages

OK.


-- 
With Best Regards,
Andy Shevchenko