linux-kernel - Re: [PATCH 2/2] mm/khugepaged: return EAGAIN for transient dirty pages in MADV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <91b218db-a9b2-4560-a946-3236947f228d@amd.com>
Date: Thu, 20 Nov 2025 12:33:41 +0530
From: "Garg, Shivank" <shivankg@....com>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 David Hildenbrand <david@...hat.com>, Zi Yan <ziy@...dia.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 "Liam R . Howlett" <Liam.Howlett@...cle.com>, Nico Pache
 <npache@...hat.com>, Ryan Roberts <ryan.roberts@....com>,
 Dev Jain <dev.jain@....com>, Barry Song <baohua@...nel.org>,
 Lance Yang <lance.yang@...ux.dev>, Steven Rostedt <rostedt@...dmis.org>,
 Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Zach O'Keefe <zokeefe@...gle.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mm/khugepaged: return EAGAIN for transient dirty
 pages in MADV_COLLAPSE

On 11/19/2025 11:46 PM, Lorenzo Stoakes wrote:
> On Wed, Nov 19, 2025 at 03:55:29PM +0530, Garg, Shivank wrote:

>>>
>>> With comments below addressed, LGTM so:
>>>
>>> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
>>
>> Thank you for the review.

>>
>> Looking at the code, the dirty/writeback checks where I'm making changes
>> are all in the !is_shmem branch, so it only affects regular files, not
>> shmem.
> 
> Yeah sorry I think I was being somehow blind to the fact that each
> dirty/writeback test has !is_shmem, esp. given I literally quote it there :)
> 
> So err ignore me I think here haha
> 
>>
>> Should I mention in the commit message that these changes are limited
>> to regular files and don't affect shmem?
> 
> No that's fine.
> 
>>
>> I'm not sure I fully understood your concern on shmem. Could you please elaborate?
> 
> Yeah I think I just misread the code after a long day :P
> 
>>

Thanks for clarifying!

I held off adding your Reviewed-by tag to v2 since there were some more changes
from v1. Let me know if you're still happy with it and I can add it for v3.

Best Regards,
Shivank