linux-kernel - RE: [PATCH v2 0/8] Add support for StarFive VisionFive 2 Lite board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <ZQ2PR01MB130738275772B0AD73099EF0E6D42@ZQ2PR01MB1307.CHNPR01.prod.partner.outlook.cn>
Date: Thu, 20 Nov 2025 02:38:04 +0000
From: Hal Feng <hal.feng@...rfivetech.com>
To: Emil Renner Berthing <emil.renner.berthing@...onical.com>, Conor Dooley
	<conor@...nel.org>
CC: E Shattow <e@...eshell.de>, Albert Ou <aou@...s.berkeley.edu>, Bjorn
 Helgaas <bhelgaas@...gle.com>, Conor Dooley <conor+dt@...nel.org>, Heinrich
 Schuchardt <heinrich.schuchardt@...onical.com>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Krzysztof Wilczyński
	<kwilczynski@...nel.org>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Manivannan Sadhasivam <mani@...nel.org>, Palmer Dabbelt <palmer@...belt.com>,
	Paul Walmsley <pjw@...nel.org>, "Rafael J . Wysocki" <rafael@...nel.org>, Rob
 Herring <robh@...nel.org>, Viresh Kumar <viresh.kumar@...aro.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 0/8] Add support for StarFive VisionFive 2 Lite board

> On 19.11.25 21:28, Emil Renner Berthing wrote:
> Quoting Conor Dooley (2025-11-19 00:10:08)
> > On Tue, Nov 18, 2025 at 02:12:58AM +0000, Hal Feng wrote:
> > > > All,
> > > >
> > > > I repeat that the suggestion was made months ago (by Hal) to split
> > > > out the OPP tables per-board from the period of time when I was
> > > > complaining about 1.5GHz JH-7110 operation pushing TDP into
> > > > over-temperature thermal limit on Milk-V Mars CM SoM.
> > > >
> > > > Whether or not JH7110S is a new compatible should follow
> > > > precedence in Linux development. JH-7110S is evidently the same
> > > > tape-out as JH-7110 and however you deal with that in Linux is the
> > > > appropriate way to deal with that here. Selection of OPP table for
> > > > correct operation will be determined by bootloader, where, it is
> > > > demonstrated by patch series sent to U-Boot upstream to be
> > > > selected ** per-board ** based on EEPROM content as if it was any
> > > > other JH-7110 board deciding dts based on EEPROM content. Given
> > > > that it is the same tape-out I do not find a valid justification
> > > > for a new compatible in the stack of adjacent software besides going
> along with some kind of marketing-driven answer about whether or not this is
> a new SoC.
> > > >
> > > > What I care about now is that the VisionFive 2 Lite series is in
> > > > good enough shape and there's a possibility to act on this
> > > > months-old suggestion to split out the OPP tables which as we have
> > > > confirmed the JH7110S is the same SoC as
> > > > JH7110 it makes a lot of sense to do.
> > > >
> > > > How is it supposed to work for binned silicon in Linux?
> > >
> > > Hi, Conor,  Emil,
> > >
> > > What do you think about this? Hope to hear from you.
> >
> > Can someone just give me a yes/no question out of this thread? I'm not
> > really immediately sure what's being asked of me. What exactly do you
> > want to do with the opp-tables? "Split out" isn't super clear. Does
> > that mean into board files? I am guessing it does, since you're saying
> > that a particular board cannot support the 1.5 GHz mode. It's not
> > unusual though to use delete node for unsupported opp-table entries,
> > could that be done instead?
> 
> Yes, as far as I can tell we should be able to just add the board description like
> this:
> 
>  jh7110.dtsi               # JH7110 SoC description
>  |- jh7110-common.dtsi     # Peripherals common to all JH7110 boards
>     |- jh7110-starfive-visionfive-2.dtsi # Peripherals common to VF2 boards
>     |  |- <VF2 boards>     # Final VF2 board descriptions
>     |- jh7110-milkv-marscm.dtsi # Peripherals common to Mars CM boards
>     |  |- <Mars CM boards> # Final Mars CM board descriptions
>     |- <other boards>      # Other JH7110 board descriptions
> +   |- jh7110-starfive-visionfive-2-lite.dts
> 
> and have it do
> 
> &cpu_opp {
>     /delete-node/ opp-375000000;
>     /delete-node/ opp-500000000;
>     /delete-node/ opp-750000000;
>     /delete-node/ opp-1500000000;
> 
>     opp-312500000 {
>         opp-hz = /bits/ 64 <312500000>;
>         opp-microvolt = <800000>;
>     };
>     opp-417000000 {
>         opp-hz = /bits/ 64 <417000000>;
>         opp-microvolt = <800000>;
>     };
>     opp-625000000 {
>         opp-hz = /bits/ 64 <625000000>;
>         opp-microvolt = <800000>;
>     };
>     opp-1250000000 {
>         opp-hz = /bits/ 64 <1250000000>;
>         opp-microvolt = <1000000>;
>     };
> };
> 
> This seems to be the minimal amount of changes needed. I looked through the
> latest OpenSBI and it does match "starfive,jh7110s", but it treats it exactly the
> same as "starfive,jh7110" and Hal have not really given any other reason we'd
> need new compatible strings.
> 
> E: I know this doesn't split out the opp table like you suggested, but I think
> that can come later if needed. Let's just start with the minimal amount of
> changes to get the VF2 Lite supported.
> 
> Hal: Do you think this could work? You might need a patch to move some mmc
> properties out of jh7110-common.dtsi

Yes, I will send out a new version with the file layout above today. Thank you.

Best regards,
Hal