linux-kernel - Re: [PATCH net v2] net: lan966x: Fix the initialization of taprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251120075057.dsjr4wgnunecgom6@DEN-DL-M31836.microchip.com>
Date: Thu, 20 Nov 2025 08:50:57 +0100
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <UNGLinuxDriver@...rochip.com>, <andrew+netdev@...n.ch>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <richardcochran@...il.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v2] net: lan966x: Fix the initialization of taprio

The 11/19/2025 20:53, Andrew Lunn wrote:
> 
> > +#define LAN9X66_CLOCK_RATE   165617754
> 
> You add a #define
> 
> > +
> >  #define LAN966X_MAX_PTP_ID   512
> >
> >  /* Represents 1ppm adjustment in 2^59 format with 6.037735849ns as reference
> > @@ -1126,5 +1129,5 @@ void lan966x_ptp_rxtstamp(struct lan966x *lan966x, struct sk_buff *skb,
> >  u32 lan966x_ptp_get_period_ps(void)
> >  {
> >       /* This represents the system clock period in picoseconds */
> > -     return 15125;
> > +     return PICO / 165617754;
> 
> and then don't use it?

Argh... that is just a stupid mistake.
I will update in the next version.

> 
>         Andrew

-- 
/Horatiu