linux-kernel - Re: [PATCH v2] dt-bindings: drm/bridge: Update reg-name and reg description list for cdns,mhdp8546 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251120-groovy-violet-tamarin-7ae42c@kuoka>
Date: Thu, 20 Nov 2025 09:01:14 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Harikrishna Shenoy <h-shenoy@...com>
Cc: robh@...nel.org, Laurent.pinchart@...asonboard.com, airlied@...il.com, 
	andrzej.hajda@...el.com, conor+dt@...nel.org, devarsht@...com, devicetree@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, jernej.skrabec@...il.com, jonas@...boo.se, krzk+dt@...nel.org, 
	linux-kernel@...r.kernel.org, maarten.lankhorst@...ux.intel.com, mripard@...nel.org, 
	neil.armstrong@...aro.org, rfoss@...nel.org, s-jain1@...com, simona@...ll.ch, 
	sjakhade@...ence.com, tzimmermann@...e.de, u-kumar1@...com, yamonkar@...ence.com, 
	pthombar@...ence.com, nm@...com
Subject: Re: [PATCH v2] dt-bindings: drm/bridge: Update reg-name and reg
 description list for cdns,mhdp8546 compatible

On Wed, Nov 19, 2025 at 05:54:47PM +0530, Harikrishna Shenoy wrote:
> Remove j721e-intg register name from reg-name list for cdns,mhdp8546
> compatible. The j721e-integ registers are specific to TI SoCs, so they
> are not required for compatibles other than ti,j721e-mhdp8546.
> 
> Move the register name constraints and reg description list to the
> appropriate compatibility sections to ensure the correct register
> names are used with each compatible value also adding the DSC register
> to make bindings align with what the hardware supports.
> 
> Fixes: 7169d082e7e6 ("dt-bindings: drm/bridge: MHDP8546 bridge binding changes for HDCP")
> Signed-off-by: Harikrishna Shenoy <h-shenoy@...com>
> ---
> 
> Links to some discussions pointing to need for a fixes patch: 
> https://lore.kernel.org/all/20250903220312.GA2903503-robh@kernel.org/
> https://lore.kernel.org/all/d2367789-6b54-4fc2-bb7c-609c0fe084d3@ti.com/
> 
> Link to v1:
> <https://lore.kernel.org/all/20251107131535.1841393-1-h-shenoy@ti.com/>
> 
> Changelog v1 --> v2:
> -Update the reg description list for each compatible and add register space
> for dsc to make the bindings reflect what hardware supports although 
> the driver doesn't support dsc yet.
> 
> Note: j721e-integ are not optional registers for ti-compatible.
> 
>  .../display/bridge/cdns,mhdp8546.yaml         | 46 ++++++++++++-------
>  1 file changed, 29 insertions(+), 17 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> index c2b369456e4e2..6de4330d13f95 100644
> --- a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> @@ -18,22 +18,9 @@ properties:
>  
>    reg:
>      minItems: 1
> -    items:
> -      - description:
> -          Register block of mhdptx apb registers up to PHY mapped area (AUX_CONFIG_P).
> -          The AUX and PMA registers are not part of this range, they are instead
> -          included in the associated PHY.
> -      - description:
> -          Register block for DSS_EDP0_INTG_CFG_VP registers in case of TI J7 SoCs.
> -      - description:
> -          Register block of mhdptx sapb registers.

You just removed completely upper constraint, so 20 items are valid...
This is exactly explained in writing schema. I expect here either oneOf
with two lists or maxItems.


>  
>    reg-names:
>      minItems: 1
> -    items:
> -      - const: mhdptx
> -      - const: j721e-intg
> -      - const: mhdptx-sapb

Please read writing schema and writing bindings.

Best regards,
Krzysztof