linux-kernel - Re: [PATCH 1/3] dt-bindings: i2c: spacemit: add optional resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251120-warping-logical-skunk-0674f8@kuoka>
Date: Thu, 20 Nov 2025 09:13:51 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Encrow Thorne <jyc0019@...il.com>
Cc: Troy Mitchell <troy.mitchell@...ux.spacemit.com>, 
	Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Yixun Lan <dlan@...too.org>, 
	Philipp Zabel <p.zabel@...gutronix.de>, Paul Walmsley <pjw@...nel.org>, 
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, 
	Alexandre Ghiti <alex@...ti.fr>, Troy Mitchell <troymitchell988@...il.com>, 
	linux-i2c@...r.kernel.org, devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	spacemit@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: i2c: spacemit: add optional resets

On Wed, Nov 19, 2025 at 07:46:43PM +0800, Encrow Thorne wrote:
> Add optional reset property for the SpacemiT K1 I2C.

Why? You just repeated diff and we can read the diff. Please explain WHY
you are doing things in terms of hardware.

> 
> Signed-off-by: Encrow Thorne <jyc0019@...il.com>
> ---
>  Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> index b7220fff2235..3d4faec41abe 100644
> --- a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> @@ -27,6 +27,9 @@ properties:
>        - description: I2C Functional Clock
>        - description: APB Bus Clock
>  
> +  resets:
> +    maxItems: 1
> +

Completely misplaced. There are never random properties between xxx and
xxx-names.

Best regards,
Krzysztof