linux-kernel - Re: [PATCH v1] ntfs3: Fix uninit buffer allocated by _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e957a100-9639-4b1e-9215-ce07ccd508c4@paragon-software.com>
Date: Thu, 20 Nov 2025 09:47:31 +0100
From: Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To: Sidharth Seela <sidharthseela@...il.com>
CC: <ntfs3@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
	<syzbot+332bd4e9d148f11a87dc@...kaller.appspotmail.com>
Subject: Re: [PATCH v1] ntfs3: Fix uninit buffer allocated by __getname()

On 9/23/25 08:40, Sidharth Seela wrote:

> Fix uninit errors caused after buffer allocation given to 'de'; by
> initializing the buffer with zeroes. The fix was found by using KMSAN.
>
> Reported-by: syzbot+332bd4e9d148f11a87dc@...kaller.appspotmail.com
> Fixes: 78ab59fee07f2 ("fs/ntfs3: Rework file operations")
> Signed-off-by: Sidharth Seela <sidharthseela@...il.com>
>
> --
>
> diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
> index 37cbbee7fa58..6b14c13bda68 100644
> --- a/fs/ntfs3/inode.c
> +++ b/fs/ntfs3/inode.c
> @@ -1716,6 +1716,7 @@ int ntfs_link_inode(struct inode *inode, struct dentry *dentry)
>   	de = __getname();
>   	if (!de)
>   		return -ENOMEM;
> +	memset(de, 0, PATH_MAX);
>   
>   	/* Mark rw ntfs as dirty. It will be cleared at umount. */
>   	ntfs_set_state(sbi, NTFS_DIRTY_DIRTY);

Patch looks good — applied. Thanks.

Regards,
Konstantin