linux-kernel - Re: [PATCH 2/4] arm64: dts: qcom: lemans: add mdss1 displayPort device nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f52beba-fca6-4dc1-ac6d-ec0a771a291e@quicinc.com>
Date: Thu, 20 Nov 2025 14:25:01 +0530
From: Mani Chandana Kuntumalla <quic_mkuntuma@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        <dmitry.baryshkov@....qualcomm.com>, <marijn.suijten@...ainline.org>,
        <swboyd@...omium.org>, <mripard@...nel.org>, <abel.vesa@...aro.org>,
        <andersson@...nel.org>, <konradybcio@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <robin.clark@....qualcomm.com>, <jessica.zhang@....qualcomm.com>,
        <abhinav.kumar@...ux.dev>, <sean@...rly.run>, <airlied@...il.com>,
        <simona@...ll.ch>, <alex.vinarskis@...il.com>
CC: <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <freedreno@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>,
        <quic_rajeevny@...cinc.com>, <quic_vproddut@...cinc.com>,
        <quic_riteshk@...cinc.com>, <quic_amitsi@...cinc.com>
Subject: Re: [PATCH 2/4] arm64: dts: qcom: lemans: add mdss1 displayPort
 device nodes



On 10/8/2025 6:10 PM, Konrad Dybcio wrote:
> On 9/26/25 10:59 AM, Mani Chandana Ballary Kuntumalla wrote:
>> Add device tree nodes for the mdss1 DPTX0 and DPTX1 controllers
>> with their corresponding PHYs.
>>
>> Signed-off-by: Mani Chandana Ballary Kuntumalla <quic_mkuntuma@...cinc.com>
>> ---
> 
> [...]
> 
>> +			mdss1_dp0: displayport-controller@...54000 {
>> +				compatible = "qcom,sa8775p-dp";
>> +
>> +				reg = <0x0 0x22154000 0x0 0x104>,
> 
> sz = 0x200
> 
>> +				      <0x0 0x22154200 0x0 0x0c0>,
> 
> sz = 0x200
> 
>> +				      <0x0 0x22155000 0x0 0x770>,
> 
> sz = 0xc00> +				      <0x0 0x22156000 0x0 0x09c>,
>> +				      <0x0 0x22157000 0x0 0x09c>,
>> +				      <0x0 0x22158000 0x0 0x09c>,
>> +				      <0x0 0x22159000 0x0 0x09c>,
> 
> sz = 0x400 for all 0x9c
> 
>> +				      <0x0 0x2215a000 0x0 0x23c>,
>> +				      <0x0 0x2215b000 0x0 0x23c>;
> 
> 0x23c -> 0x600
> 
> [...]
> 
> 
>> +			mdss1_dp1: displayport-controller@...5c000 {
>> +				compatible = "qcom,sa8775p-dp";
>> +
>> +				reg = <0x0 0x2215c000 0x0 0x104>,
>> +				      <0x0 0x2215c200 0x0 0x0c0>,
>> +				      <0x0 0x2215d000 0x0 0x770>,
>> +				      <0x0 0x2215e000 0x0 0x09c>,
>> +				      <0x0 0x2215f000 0x0 0x09c>,
>> +				      <0x0 0x22160000 0x0 0x09c>,
>> +				      <0x0 0x22161000 0x0 0x09c>,
>> +				      <0x0 0x22162000 0x0 0x23c>,
>> +				      <0x0 0x22163000 0x0 0x23c>;
> 
> 0x2216_2000 and _3000 don't exist, there's no MST2/3
> 
> sizes should be changed similarly

MST2/3 is supported for MDSS1 DPTX0.

> 
> [...]
> 
>>   		dispcc1: clock-controller@...00000 {
>> @@ -6872,6 +7115,8 @@ dispcc1: clock-controller@...00000 {
>>   				 <&rpmhcc RPMH_CXO_CLK>,
>>   				 <&rpmhcc RPMH_CXO_CLK_A>,
>>   				 <&sleep_clk>,
>> +				 <&mdss1_dp0_phy 0>, <&mdss1_dp0_phy 1>,
>> +				 <&mdss1_dp1_phy 0>, <&mdss1_dp1_phy 1>,
>>   				 <0>, <0>, <0>, <0>,
> 
> You need to remove the same amount of zeroes that you added
> 

Sure, Will update this in the next version.

> Konrad
> 
>>   				 <0>, <0>, <0>, <0>;
>>   			power-domains = <&rpmhpd SA8775P_MMCX>;