linux-kernel - Re: [PATCH v7 00/22] wifi: nxpwifi: create nxpwifi to support iw61x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2b976b880158605ecf74ca01420c184434371e2f.camel@sipsolutions.net>
Date: Thu, 20 Nov 2025 10:01:12 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Jeff Johnson <jeff.johnson@....qualcomm.com>, Jeff Chen
	 <jeff.chen_1@....com>, linux-wireless@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, briannorris@...omium.org, 
	francesco@...cini.it, tsung-hsien.hsieh@....com, s.hauer@...gutronix.de
Subject: Re: [PATCH v7 00/22] wifi: nxpwifi: create nxpwifi to support iw61x

On Mon, 2025-11-17 at 11:10 -0800, Jeff Johnson wrote:
> So that this series would have an additional set of eyes I ran this through
> the automation I use for ath.git.

Cool :)

> It reports multiple instances of using the now obsolete networking multi-line
> comment style.
> Starting from the first patch:
> +/* Fills HT capability information field, AMPDU Parameters field, HT extended
> +/* This function returns the pointer to an entry in BA Stream
> +/* This function handles the command response of delete a block
> ...
> 
> Current guidance is to use the standard multi-line comment style
> /*
>  * first line of comment
>  * [more lines of comment]
>  * last line of commnt
>  */

I guess I'm not going to worry too much about that, but yeah, we did
drop the special networking style even if checkpatch still accepts it.


> It also flagged one incorrect use of kernel-doc comment style:
> +       /** rate for LG pkt, RATE flag will be present, it shows datarate in
> 
> There are also numerous spelling issues reported by checkpatch.pl --codespell
> TYPO_SPELLING: 'interation' may be misspelled - perhaps 'iteration'?
> TYPO_SPELLING: 'Dimentions' may be misspelled - perhaps 'Dimensions'?
> TYPO_SPELLING: 'interfacces' may be misspelled - perhaps 'interfaces'?
> TYPO_SPELLING: 'formate' may be misspelled - perhaps 'format'?
> TYPO_SPELLING: 'verion' may be misspelled - perhaps 'version'?
> TYPO_SPELLING: 'Timstamp' may be misspelled - perhaps 'Timestamp'?
> TYPO_SPELLING: 'intializes' may be misspelled - perhaps 'initializes'?
> TYPO_SPELLING: 'statistc' may be misspelled - perhaps 'statistic'?

:)

> Also "wifi: nxpwifi: add initial SDIO bus driver support" reports
> UNDOCUMENTED_DT_STRING: DT compatible string "nxp,iw61x" appears un-documented
> -- check ./Documentation/devicetree/bindings/
> 
> Is there an associated DT patch out there?

Oh, ouch, this is something you should resolve I think, so that it's
documented (and correctly so) before getting used. I'm not really
familiar with the process though.

johannes