linux-kernel - Re: [PATCH] spi: cs42l43: Use actual ACPI firmware node for chip selects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aR7oMlVpUL9prRLs@opensource.cirrus.com>
Date: Thu, 20 Nov 2025 10:06:42 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: broonie@...nel.org, linus.walleij@...aro.org, andy@...nel.org,
        p.zabel@...gutronix.de, linux-gpio@...r.kernel.org,
        linux-spi@...r.kernel.org, bartosz.golaszewski@...aro.org,
        linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH] spi: cs42l43: Use actual ACPI firmware node for chip
 selects

On Thu, Nov 20, 2025 at 10:29:41AM +0100, Bartosz Golaszewski wrote:
> On Wed, Nov 19, 2025 at 5:40 PM Charles Keepax
> <ckeepax@...nsource.cirrus.com> wrote:
> > +               props = devm_kmemdup(priv->dev, cs42l43_cs_props, sizeof(cs42l43_cs_props),
> > +                                    GFP_KERNEL);
> > +               if (!props)
> > +                       return -ENOMEM;
> 
> You don't need to allocate it for more than the duration of this
> function, device_create_managed_software_node() makes a deep copy of
> the properties. They can be on the stack.

Good point, thanks will fixup for v2. Should be able to send that
later today.

> This is looking good, if you post a v2 and it's reviewed, I can resend
> my series with this included and maybe it'll still make v6.19.

Cool yeah I am fine with you pulling this into your series once I
have sent the v2.

Thanks,
Charles